Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bringing some dependencies in house #93

Open
oleg-alexandrov opened this issue May 16, 2023 · 3 comments
Open

Bringing some dependencies in house #93

oleg-alexandrov opened this issue May 16, 2023 · 3 comments

Comments

@oleg-alexandrov
Copy link
Contributor

Back when Isaac started we looked around at the best packages to use for some of the work that we then built on. That was a good thing, but longer term having the isaac repo depend on third-party repos that may go away without notice is likely a fragile state of things.

When there's more dev time, perhaps one can look at this list of third-party deps, https://github.com/oleg-alexandrov/mvs-texturing/blob/isaac/elibs/CMakeLists.txt, and switch those to some forked repos under nasa/isaac. Even my own repo, as seen above, should be forked I think.

This came about because I managed to break some stuff in those dependencies (that I fixed with Marina). That was made robust now, by ensure a specific version is checked out, but the longer term dependency on repos whose history may be rewritten or even they may be deleted is still there.

@marinagmoreira
Copy link
Member

@bcoltin what are your thoughts on this? Even now we're adding more and more forked repos in our accounts, I have a couple as well as Brian K. But I don't think we can have forks under nasa/isaac and an organizations can't fork repos under the free account (and that would be a big hassle)

@bcoltin
Copy link
Member

bcoltin commented Mar 26, 2024

I think this is a good idea but the effort / reward ratio is very poor. I think if we do want to make this more robust, our effort would be better spent getting the minor patches we need merged upstream if possible...

@trey0
Copy link
Contributor

trey0 commented Jul 10, 2024

A simple though imperfect way to make this more robust would be: for every place we depend on a repo personal fork, make sure there is a redundant personal fork containing the same required frozen commit, and keep some notes about where those redundant forks are in case we need to swap out a broken link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants