Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enh]: Add support for Binary & Time datatype #1989

Open
2 tasks
FBruzzesi opened this issue Feb 11, 2025 · 5 comments
Open
2 tasks

[Enh]: Add support for Binary & Time datatype #1989

FBruzzesi opened this issue Feb 11, 2025 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers, but anyone is welcome to submit a pull request!

Comments

@FBruzzesi
Copy link
Member

FBruzzesi commented Feb 11, 2025

Description

We have support for the large majority of polars dtypes, yet missing a few:

@FBruzzesi FBruzzesi added the enhancement New feature or request label Feb 11, 2025
@dangotbanned
Copy link
Member

We have support for the large majority of polars dtypes, yet missing a few. One of which is Binary

@FBruzzesi another one that I noted in altair.datasets._cache, was Time.
I haven't seen an issue for it before, but would have thought Time might be more common to use than Binary?

Feel free to move this to another issue, just wanted to collect some knowledge on missing types:

General

Implementations

@MarcoGorelli
Copy link
Member

thanks both

I think we should have both data types - even if we can't always support casting to it for all backends, if these datatypes are present, we should at least reported them as Time / Binary as opposed to Unknown

@FBruzzesi
Copy link
Member Author

Thanks for pointing that out @dangotbanned , I will edit the issue in a bit to be more comprehensive for all the missing types

@dangotbanned
Copy link
Member

Thanks @MarcoGorelli, @FBruzzesi

Just to argue against myself a little bit on nw.Time from L75

    # nw.Time: "time" (Not Implemented, but we don't have any cases using it anyway)

Per #1942:

Freeze new features which don't have a use case.

I think it makes sense to support, but I'm not losing any sleep over the status quo 🙂

@MarcoGorelli
Copy link
Member

I think this fine, a couple new data types doesn't really add much bloat (as opposed to, say, implementing an entire new namespace)

@FBruzzesi FBruzzesi changed the title [Enh]: Add support for Binary datatype [Enh]: Add support for Binary & Time datatype Feb 14, 2025
@FBruzzesi FBruzzesi added the good first issue Good for newcomers, but anyone is welcome to submit a pull request! label Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers, but anyone is welcome to submit a pull request!
Projects
None yet
Development

No branches or pull requests

3 participants