Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement load_replace_candidate() #40

Open
kace opened this issue Nov 10, 2021 · 4 comments
Open

Implement load_replace_candidate() #40

kace opened this issue Nov 10, 2021 · 4 comments

Comments

@kace
Copy link
Contributor

kace commented Nov 10, 2021

This method isn't supported according to the readme, but in practice the function call seems to work if we define a dest_file. It's a one line change other than adding tests (not sure if tests are done for anything besides getters?).

Same thing as for #39 I'm trying to push my local fixes upstream.

@housepbass
Copy link

I would be very happy to have this functionality. Any status updates on progress?

@kace
Copy link
Contributor Author

kace commented Jan 6, 2022

Ah. I've totally forgotten about this. I'll see if I can make time this weekend for it.

@housepbass
Copy link

Hey Kace, have you had a chance to work on this? I’m about to do a huge OS10 rollout and this would be supremely helpful.

@housepbass
Copy link

housepbass commented Feb 17, 2022

What's the one-line change that implements this function? Also, it looks like the operation isn't defined. I have a suspicion this may not be possible as dellos10 doesn't have 'replace candidate' functionality. Is that correct?

    if self.config_replace:
        # Replace operation
        raise NotImplementedError("Configuration not supported")
    else:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants