Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test multiple sketch files #17

Open
chrisachard opened this issue Oct 20, 2017 · 7 comments
Open

Test multiple sketch files #17

chrisachard opened this issue Oct 20, 2017 · 7 comments

Comments

@chrisachard
Copy link
Collaborator

There is a great set of sketch files here: https://www.invisionapp.com/do

Download and test them, and report any errors as issues.

@chrisachard
Copy link
Collaborator Author

Also, if you have any other good React Native Sketch templates resources, leave a comment here with a link!

@Rob-Rychs
Copy link

Started working on this issue.

@Rob-Rychs
Copy link

That do-sketch library has 130 exportable svgs so I created a separate repo to start testing them, here are the first 13 (or row 1) of svgs with their errors listed in readme, svgs in images folder and generated output files/folders in respective component folders https://github.com/Rob-Rychs/do-sketch-to-react-native-test

@chrisachard
Copy link
Collaborator Author

chrisachard commented Oct 26, 2017 via email

@horacioh
Copy link

horacioh commented Nov 6, 2017

I test one of my files & it was not a good result.
you can see the result here: https://snack.expo.io/HkyvLL0CW
here is all the files related to my test (sketch file, output): https://www.dropbox.com/s/2friwhozpgn9v7c/sketch-to-react-native_test.tar.gz?dl=0

is there anything I can do to help let me know!

@chrisachard
Copy link
Collaborator Author

Sorry it didn't work well for you. Uploading your sketch file was great, thanks! That is the most helpful thing we can have - examples. We're working on the next version, which should fix some of the problems you're seeing... Once we get the sketch plugin (for better asset exports), and the new neural net (that can detect buttons, etc), the output should be much improved.

@horacioh
Copy link

horacioh commented Nov 6, 2017

hey its fine! this is a really awesome project I was curious to test.

THANK YOU to open source it! 🙏🏻🙏🏻👏🏻👏🏻👏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants