-
-
Notifications
You must be signed in to change notification settings - Fork 12
Update 1 NuGet dependencies #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 1 NuGet dependencies #440
Conversation
Bumps nanoFramework.System.Device.Wifi from 1.5.137 to 1.5.138</br> [version update] ###⚠️ This is an automated update.⚠️
WalkthroughTwo packages.lock.json files are updated to bump the nanoFramework.System.Device.Wifi dependency from version 1.5.137 to 1.5.138, with corresponding contentHash updates. No logic, API, or method signature changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes The changes are homogeneous, repetitive dependency version updates with no logic or structural modifications, requiring only verification that the version bump and hash values are correct. Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (4)
TestMqtt/TestAppv5.0/TestAppv5.0.nfprojis excluded by none and included by noneTestMqtt/TestAppv5.0/packages.configis excluded by none and included by noneTests/MemoryLeakTestApp/MemoryLeakTestApp.nfprojis excluded by none and included by noneTests/MemoryLeakTestApp/packages.configis excluded by none and included by none
📒 Files selected for processing (2)
TestMqtt/TestAppv5.0/packages.lock.json(1 hunks)Tests/MemoryLeakTestApp/packages.lock.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: nanoframework.m2mqtt (Build_Library)
🔇 Additional comments (3)
TestMqtt/TestAppv5.0/packages.lock.json (1)
19-21: Verify nanoFramework.System.Device.Wifi v1.5.138 existence before merge.nanoFramework.System.Device.Wifi provides the System.Device.Wifi assembly for .NET nanoFramework C# projects. However, the update to v1.5.138 is not visible in current NuGet search results (latest found: v1.5.134). Confirm that:
- Version 1.5.138 has been released or is scheduled for release
- The contentHash "GYVXvPRRkjT8/dFTPDbeUrzvVIEqIpaU8zZMyoN/YoE/4BfmzKVg/9CMbIvnocQCl7UJdwi3qnseqVIm71ZJlQ==" is correct for this version
- The build will not fail due to an unavailable package version
Tests/MemoryLeakTestApp/packages.lock.json (2)
25-27: Consistent dependency update across test projects.The update to nanoFramework.System.Device.Wifi v1.5.138 is consistent with TestMqtt/TestAppv5.0/packages.lock.json (identical contentHash). Both lock files are properly synchronized.
25-27: Consistent update across test projects, but verify package availability.Both lock files are synchronized with the same nanoFramework.System.Device.Wifi v1.5.138 and identical contentHash. However, this version is not yet visible in standard NuGet search results. Ensure the update doesn't cause restore failures during CI/CD.
| "requested": "[1.5.138, 1.5.138]", | ||
| "resolved": "1.5.138", | ||
| "contentHash": "GYVXvPRRkjT8/dFTPDbeUrzvVIEqIpaU8zZMyoN/YoE/4BfmzKVg/9CMbIvnocQCl7UJdwi3qnseqVIm71ZJlQ==" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Verify nanoFramework.System.Device.Wifi v1.5.138 package integrity.
The update is a patch version bump with consistent contentHash across both lock files. Verify that the package exists, is legitimate, and the contentHash matches the official NuGet distribution.
🌐 Web query:
nanoFramework.System.Device.Wifi 1.5.138 NuGet package verification
💡 Result:
I couldn't find a nanoFramework.System.Device.Wifi 1.5.138 release on NuGet. The latest listed on nuget.org is 1.5.137. [1]
To verify a package/release and its native-checksum/version, check the package page on NuGet (package metadata and version list) and the nanoFramework docs on package/assembly checksums for how native checksums are produced and recorded. [1][2]
Sources:
- nanoFramework.System.Device.Wifi package page (nuget.org) — shows latest v1.5.137. [1]
- .NET nanoFramework — Package and assembly versions and checksums (documentation). [2]
Remove the invalid nanoFramework.System.Device.Wifi 1.5.138 reference.
The latest available version of nanoFramework.System.Device.Wifi on NuGet is 1.5.137, and v1.5.138 is not available. Revert the lock file to version 1.5.137 or wait until v1.5.138 is officially released on NuGet. Using a non-existent package version will cause build failures during dependency restoration.
🤖 Prompt for AI Agents
In TestMqtt/TestAppv5.0/packages.lock.json around lines 19-21, the lock file
references nanoFramework.System.Device.Wifi v1.5.138 which does not exist on
NuGet; replace the entry to point to the valid v1.5.137 (update "requested" and
"resolved" to "[1.5.137, 1.5.137]" and "1.5.137" respectively and remove or
replace the contentHash with the correct hash) or remove the invalid entry and
regenerate the lock file by restoring packages (run the project restore/nuget
restore/dotnet restore) so the lock file is recreated with the correct published
version; alternatively, wait for v1.5.138 to be published and then regenerate
the lock file.
|



Bumps nanoFramework.System.Device.Wifi from 1.5.137 to 1.5.138
[version update]
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.