Update specs and improve compatibility with latest Redmine version

Author: nanego

.github/workflows/5_1_5.yml renamed to .github/workflows/5_1_9.yml

@@ -1,8 +1,8 @@
-name: Tests 5.1.5
+name: Tests 5.1.9
 
 env:
   PLUGIN_NAME: redmine_datetime_custom_field
-  REDMINE_VERSION: 5.1.5
+  REDMINE_VERSION: 5.1.9
   RAILS_ENV: test
 
 on:

.github/workflows/6_0_2.yml renamed to .github/workflows/6_0_6.yml

@@ -1,8 +1,8 @@
-name: Tests 6.0.2
+name: Tests 6.0.6
 
 env:
   PLUGIN_NAME: redmine_datetime_custom_field
-  REDMINE_VERSION: 6.0.2
+  REDMINE_VERSION: 6.0.6
   RAILS_ENV: test
 
 on:

README.md

@@ -12,8 +12,8 @@ Note that this plugin has a dependency. You have to install this other plugin:
 
 |Plugin branch| Redmine Version | Test Status       |
 |-------------|-----------------|-------------------|
-|master       | 6.0.2           | [![6.0.2][1]][5]  |
-|master       | 5.1.5           | [![5.1.5][2]][5]  |
+|master       | 6.0.6           | [![6.0.6][1]][5]  |
+|master       | 5.1.9           | [![5.1.9][2]][5]  |
 |master       | master          | [![master][4]][5] |
 
 [1]: https://github.com/nanego/redmine_datetime_custom_field/actions/workflows/6_0_2.yml/badge.svg

lib/redmine_datetime_custom_field/application_helper_patch.rb

@@ -6,10 +6,29 @@
 
 module RedmineDatetimeCustomField
   module ApplicationHelperPatch
-    def format_object(object, html = true, &block)
-      if (object.class.name == 'CustomValue' || object.class.name == 'CustomFieldValue') && object.custom_field
+    def format_object(object, *args, &block)
+
+      if (object.is_a?(CustomValue) || object.is_a?(CustomFieldValue)) && object.custom_field.present?
         return "" unless object.customized&.visible?
-        f = object.custom_field.format.formatted_custom_value(self, object, html)
+
+        options =
+          if args.first.is_a?(Hash)
+            args.first
+          elsif !args.empty?
+            # Support the old syntax `format_object(object, html_flag)`
+            # TODO: Display a deprecation warning in a future version, then remove this
+            {:html => args.first}
+          else
+            {}
+          end
+        html = options.fetch(:html, true)
+
+        if self.respond_to?(:simple_format)
+          f = object.custom_field.format.formatted_custom_value(self, object, html: html)
+        else
+          return super
+        end
+
         if f.nil? || f.is_a?(String)
           f
         else

spec/checksums_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+describe "Checksums" do
+  def assert_checksum(expected, filename)
+    filepath = Rails.root.join(filename)
+    checksum = Digest::MD5.hexdigest(File.read(filepath))
+    assert checksum.in?(Array(expected)), "Bad checksum for file: #{filename}, local version should be reviewed: checksum=#{checksum}, expected=#{Array(expected).join(" or ")}"
+  end
+
+  it "checks core file application_helper checksums" do
+    # several methods are overridden and should be reviewed if the checksum change
+    # version 6.0.6 is OK
+    assert_checksum %w"ba954d7d5c77ecd13256f2bef721db73", "app/helpers/application_helper.rb"
+  end
+end

spec/helpers/application_helper_patch_spec.rb

@@ -1,4 +1,4 @@
-require File.dirname(__FILE__) + '/../spec_helper'
+require 'spec_helper'
 require_relative '../../lib/redmine_datetime_custom_field/application_helper_patch'
 
 describe ApplicationHelper, type: :helper do