Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It should be clear in the Readme what protocols it supports #46

Open
Buzut opened this issue Oct 23, 2016 · 10 comments
Open

It should be clear in the Readme what protocols it supports #46

Buzut opened this issue Oct 23, 2016 · 10 comments

Comments

@Buzut
Copy link

Buzut commented Oct 23, 2016

Currently it's not very clear what is supported and what is not. From the provided exemple, I can infer that the lib sends data on UDP, but is there a way to support TCP, TCP over TLS, HTTP?

Thank you for making that clear. And thank you for maintaining this project!

@kwisatz
Copy link

kwisatz commented Jan 27, 2017

👍

@odino
Copy link
Contributor

odino commented Jan 29, 2017

Hey guys,

we send messages through graylog2 which I think supports UDP only (I might be wrong :-P). In general, though, I would only bother to support UDP in this context.

@kwisatz
Copy link

kwisatz commented Jan 29, 2017

@odino graylog2 supports a wide range of inputs and protocols, most prominently GELF over UDP, TCP and HTTP.

Having UDP only is OK as a choice (although having HTTP too would be nice) but having the Readme state so would improve the module's UX.

@Buzut
Copy link
Author

Buzut commented Jan 29, 2017

In case someone needs to support HTTP or TCP, I've written a transport for Winston that supports them: winston-log2gelf.

@odino
Copy link
Contributor

odino commented Jan 29, 2017

@kwisatz Im aware of that, even though Im not sure who would like to log via HTTP :) Anyway, as I said, we simply rely on graylog2 (the NPM module) to talk to the graylog server, so whatever protocols are supported by that module will be supported by this transport. Hope that clarifies!

@kwisatz
Copy link

kwisatz commented Jan 29, 2017

@odino Alright, sorry, I hadn't followed your link, believing it would lead me to the Graylog 2 website.
Logging via HTTP(s) makes sense in environments where you don't have access to other ports or protocols.

@Buzut
Copy link
Author

Buzut commented Jan 29, 2017

@odino @kwisatz Although I agree that the HTTP case is not very common, UDP isn't secure by design. In an environement that doesn't offer a secure network to send the logs over, using UDP isn't acceptable as logs carry sensible information.

@odino
Copy link
Contributor

odino commented Jan 29, 2017

@kwisatz no worries! I assume that module might let you use other protocols, though Im not sure :)

@odino
Copy link
Contributor

odino commented Jan 29, 2017

@Buzut sure, though even with HTTP you dont get security -- and I believe HTTPS might be too expensive. I would be surprised to see massive deployments with logging happening via HTTPS :)

@Buzut
Copy link
Author

Buzut commented Jan 29, 2017

@odino With keepalive wisely configured, the overhead isn't that impacting. Plus it depends on what you log and the amount of data. Logging from a website's frontend for instance, is only possibe through HTTP (but that's out of scope for a winston transport anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants