-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing "miniupnpc/" include paths #180
Comments
If I understand you correctly you suggest that we should (re)add the path "minipunpnc/" in the includes? I will edit your post a little to clarify. |
Linux distributions vary in miniupnp include paths. In my packages I have solved the problem by invoking qmake with "INCLUDEPATH=/usr/include/miniupnpc" and "make -C src OPENSSL_INCLUDE_PATH=/usr/include/miniupnpc" for the daemon. |
@phelixbtc Namecoin failed to build for me with UPNP enabled (Debian Wheezy) after your commit. Since I don't want UPNP anyway, I did just disable it so far, which works well for me. I don't know what exactly the problem is or how to fix it correctly (never tried to find it out due to lack of interest in UPNP). |
@pmconrad would it be a problem for you if we would add the paths again? |
If anything breaks I'll find a workaround... |
@cassiniNMC In EasyWinBuilder I would have to hack around (changing the source file, copying object files or renaming the miniupnpc folder). I wonder how a clean solution to this could look like? Anyway for now I would prefer #ifdef APPLE and leave the other systems alone. |
28e7e65 breaks my build on Ubuntu 14.04 as well. I believe rather than explicitly breaking the build on Linux (and OSX?) systems, hacking around EasyWinBuilder's issues is the correct solution. Technically this a hack anyways since the correct include is |
OK then. #196 |
The absence of "miniupnpc/" of the #include lines in net.cpp is incompatible with some of the package managers.
The text was updated successfully, but these errors were encountered: