CategoricalArray fixes #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix mixing CategoricalArray with other kinds of arrays, which failed
due to problems with how NamedArrays handles CategoricalArray dimnames:
now we always unwrap categorical values when creating dimension names.
Fix the type of the dimnames vector when only CategoricalArrays are passed:
before this it was always Union{T, Missing}. Change it to always use the same eltype
as the input, which is consistent with other AbstractArrays.
|
Actually, unwrapping categorical values may not be a good idea, as that makes it impossible to index the table with |
|
The last commit reverts the unwrapping of categorical values. Tests will fail until the new NamedArrays release. |
nalimilan
commented
Feb 19, 2020
| @@ -77,15 +81,35 @@ cy = CategoricalArray(y) | |||
| tab = @inferred freqtable(cx) | |||
| @test tab == [100, 100, 100, 100] | |||
| @test names(tab) == [["a", "b", "c", "d"]] | |||
| @test names(tab, 1) isa Array{eltype(cx)} | |||
| @test_broken names(tab, 1) isa typeof(cx) | |||
There was a problem hiding this comment.
This will be fixed by JuliaData/CategoricalArrays.jl#252. In practice it shouldn't make a big difference anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix mixing
CategoricalArraywith other kinds of arrays, which failed due to problems with howNamedArrayshandlesCategoricalArraydimnames: now we always unwrap categorical values when creating dimension names.Fix the type of the dimnames vector when only
CategoricalArraysare passed: before this it was alwaysUnion{T, Missing}. Change it to always use the same eltype as the input, which is consistent with otherAbstractArrays.Fixes #45.