SLF4J binding warning on console

- Updates Logback to new version in case of Flight Evaluation Report to resolve mismatch caused by transitive dependencies

Resolves #197
{patch}

Signed-off-by: Esta Nagy <[email protected]>

Author: nagyesta

boosters/testkit/build.gradle

@@ -9,7 +9,7 @@ dependencies {
     implementation project(":mission-control")
     implementation libs.spring.boot.starter
     implementation libs.spring.boot.starter.test
-    implementation libs.bundles.logback
+    implementation libs.bundles.logback.test
     testImplementation libs.jupiter.api
     testImplementation libs.jupiter.core
     constraints {

gradle/libs.versions.toml

@@ -4,8 +4,9 @@ springBoot = "2.7.6"
 snakeYaml = "1.33"
 thymeleaf = "3.1.0.RELEASE"
 thymeleafExtrasTime = "3.0.4.RELEASE"
-logback = "1.2.11"
+logbackTest = "1.2.11"
 jsonSchemaValidator = "1.0.74"
+logbackReport = "1.4.5"
 jackson = "2.14.1"
 gson = "2.10"
 slf4j = "1.7.36"
@@ -43,8 +44,10 @@ snake-yaml = { module = "org.yaml:snakeyaml", version.ref = "snakeYaml" }
 thymeleaf = { module = "org.thymeleaf:thymeleaf", version.ref = "thymeleaf" }
 thymeleaf-extras-java8time = { module = "org.thymeleaf.extras:thymeleaf-extras-java8time", version.ref = "thymeleafExtrasTime" }
 
-logback-classic = { module = "ch.qos.logback:logback-classic", version.ref = "logback" }
-logback-core = { module = "ch.qos.logback:logback-core", version.ref = "logback" }
+logback-classic-test = { module = "ch.qos.logback:logback-classic", version.ref = "logbackTest" }
+logback-core-test = { module = "ch.qos.logback:logback-core", version.ref = "logbackTest" }
+logback-classic-report = { module = "ch.qos.logback:logback-classic", version.ref = "logbackReport" }
+logback-core-report = { module = "ch.qos.logback:logback-core", version.ref = "logbackReport" }
 
 gson = { module = "com.google.code.gson:gson", version.ref = "gson" }
 json-schema-validator = { module = "com.networknt:json-schema-validator", version.ref = "jsonSchemaValidator" }
@@ -76,7 +79,8 @@ cucumber-spring = { module = "io.cucumber:cucumber-spring", version.ref = "cucum
 
 [bundles]
 spring-test = ["spring-core", "spring-context", "spring-test", "snake-yaml"]
-logback = ["logback-classic", "logback-core"]
+logback-test = ["logback-classic-test", "logback-core-test"]
+logback-report = ["logback-classic-report", "logback-core-report"]
 
 [plugins]
 lombok = { id = "io.freefair.lombok", version.ref = "lombokPlugin" }

gradle/verification-metadata.xml

@@ -31,6 +31,14 @@
             <sha256 value="64e01794db4659829862a44574e066bf6940678fb1657e26668bf6414596244d" origin="Generated by Gradle"/>
          </artifact>
       </component>
+      <component group="ch.qos.logback" name="logback-classic" version="1.4.5">
+         <artifact name="logback-classic-1.4.5.jar">
+            <sha256 value="595431df58c74d515dd4c225b2d84d9f23e16a24daeaafd7c94b059312a8b493" origin="Generated by Gradle"/>
+         </artifact>
+         <artifact name="logback-classic-1.4.5.pom">
+            <sha256 value="8bfb0ea99168c5f1c63888bbe5eacb4b7eacdf8a2d2226d9b0c023f3b5887fde" origin="Generated by Gradle"/>
+         </artifact>
+      </component>
       <component group="ch.qos.logback" name="logback-core" version="1.2.11">
          <artifact name="logback-core-1.2.11.jar">
             <sha256 value="6ce1e9397be8298a2e99029f55f955c6fa3cef255171c554d0b9c201cffd0159" origin="Generated by Gradle"/>
@@ -39,11 +47,24 @@
             <sha256 value="53074a2590e0d64da5bd5b09cfe4a9c1cfcbf987e503940e8184ee39fe855d14" origin="Generated by Gradle"/>
          </artifact>
       </component>
+      <component group="ch.qos.logback" name="logback-core" version="1.4.5">
+         <artifact name="logback-core-1.4.5.jar">
+            <sha256 value="8604e7c327556b097590701fba88dae84c581167f2746378f736b37269452380" origin="Generated by Gradle"/>
+         </artifact>
+         <artifact name="logback-core-1.4.5.pom">
+            <sha256 value="68988021b6ecbf3d40fb74a3e8561e87ae66edc3a6d84e5c100880bea3208891" origin="Generated by Gradle"/>
+         </artifact>
+      </component>
       <component group="ch.qos.logback" name="logback-parent" version="1.2.11">
          <artifact name="logback-parent-1.2.11.pom">
             <sha256 value="c3c0f80dfb31aa922f8c60fe22c24b04eee41aa9a17466cdd85d81474196d1ef" origin="Generated by Gradle"/>
          </artifact>
       </component>
+      <component group="ch.qos.logback" name="logback-parent" version="1.4.5">
+         <artifact name="logback-parent-1.4.5.pom">
+            <sha256 value="af2ef873616180481564afb295b877d7558077cca9a3786b90ce5407b9434acc" origin="Generated by Gradle"/>
+         </artifact>
+      </component>
       <component group="com.beust" name="jcommander" version="1.82">
          <artifact name="jcommander-1.82.jar">
             <sha256 value="deeac157c8de6822878d85d0c7bc8467a19cc8484d37788f7804f039dde280b1" origin="Generated by Gradle"/>
@@ -2165,13 +2186,18 @@
          </artifact>
       </component>
       <component group="org.slf4j" name="slf4j-api" version="2.0.3">
-         <artifact name="slf4j-api-2.0.3.jar">
-            <sha256 value="68ddcda65300ff8097ad1a096d7cd2fb06cef25193887cec3f2690e01bdbf421" origin="Generated by Gradle"/>
-         </artifact>
          <artifact name="slf4j-api-2.0.3.pom">
             <sha256 value="1b2985de22fda3ee76cd564ad106fb291b73439ec3c544be3d3242c6f7a26b46" origin="Generated by Gradle"/>
          </artifact>
       </component>
+      <component group="org.slf4j" name="slf4j-api" version="2.0.4">
+         <artifact name="slf4j-api-2.0.4.jar">
+            <sha256 value="57fa874599ace9259286b99253d7a877afdd2db4b07a6827ac6c847ca5d601a2" origin="Generated by Gradle"/>
+         </artifact>
+         <artifact name="slf4j-api-2.0.4.pom">
+            <sha256 value="85b1af0535665ce8f23a2b9f1f581cc1e7877bb1289304140827731216c78ffd" origin="Generated by Gradle"/>
+         </artifact>
+      </component>
       <component group="org.slf4j" name="slf4j-parent" version="1.7.2">
          <artifact name="slf4j-parent-1.7.2.pom">
             <sha256 value="1d8e084a6f2384ade42685332b52a0ece090478641dc14c0fa8c52e1e2984425" origin="Generated by Gradle"/>
@@ -2207,6 +2233,11 @@
             <sha256 value="78293303db8c626674935fde8428baff8aaaacfc93ec461168692c92c8472339" origin="Generated by Gradle"/>
          </artifact>
       </component>
+      <component group="org.slf4j" name="slf4j-parent" version="2.0.4">
+         <artifact name="slf4j-parent-2.0.4.pom">
+            <sha256 value="dc9dc87f53a8af721ee49dbb521bd06cda06134214fdad9400d872a75426cffd" origin="Generated by Gradle"/>
+         </artifact>
+      </component>
       <component group="org.sonatype.aether" name="aether" version="1.13.1">
          <artifact name="aether-1.13.1.pom">
             <sha256 value="719fe091fd3fe4c6a7b8f69c8714935138b85a2b6145068a1ccfdb57d2e500d1" origin="Generated by Gradle"/>

mission-report/flight-evaluation-report/build.gradle

@@ -17,7 +17,7 @@ dependencies {
     implementation libs.jackson.databind
     implementation libs.thymeleaf
     implementation libs.thymeleaf.extras.java8time
-    implementation libs.bundles.logback
+    implementation libs.bundles.logback.report
     implementation libs.findbugs.jsr305
     annotationProcessor libs.lombok
     testImplementation libs.jupiter.core

mission-report/flight-evaluation-report/src/main/java/com/github/nagyesta/abortmission/reporting/PropertiesParser.java

@@ -10,8 +10,14 @@
 
 public final class PropertiesParser {
 
-    private static final String INPUT = "--report.input";
-    private static final String OUTPUT = "--report.output";
+    /**
+     * The parameter name of the input file.
+     */
+    public static final String INPUT = "--report.input";
+    /**
+     * The parameter name of the output file.
+     */
+    public static final String OUTPUT = "--report.output";
     private static final String RELAXED = "--report.relaxed";
     private static final String FAIL_ON_ERROR = "--report.failOnError";
     private static final String EQUALS = "=";

mission-report/flight-evaluation-report/src/main/java/com/github/nagyesta/abortmission/reporting/config/ConversionProperties.java

@@ -1,10 +1,13 @@
 package com.github.nagyesta.abortmission.reporting.config;
 
 import lombok.Data;
-import lombok.NonNull;
 
 import javax.annotation.Nonnull;
 import java.io.File;
+import java.util.Optional;
+
+import static com.github.nagyesta.abortmission.reporting.PropertiesParser.INPUT;
+import static com.github.nagyesta.abortmission.reporting.PropertiesParser.OUTPUT;
 
 @Data
 public final class ConversionProperties {
@@ -13,9 +16,12 @@ public final class ConversionProperties {
     private boolean relaxed;
     private boolean failOnError;
 
-    private ConversionProperties(@NonNull final File input, @NonNull final File output, final boolean relaxed, final boolean failOnError) {
-        this.input = input;
+    private ConversionProperties(final File input, final File output, final boolean relaxed, final boolean failOnError) {
+        this.input = Optional.ofNullable(input)
+                .orElseThrow(() -> new IllegalArgumentException("Missing input parameter. Expected: " + INPUT + "=<file.json>"));
         this.output = output;
+        Optional.ofNullable(output)
+                .orElseThrow(() -> new IllegalArgumentException("Missing output parameter. Expected: " + OUTPUT + "=<file.html>"));
         this.relaxed = relaxed;
         this.failOnError = failOnError;
     }

strongback/strongback-base/build.gradle

@@ -10,7 +10,7 @@ dependencies {
     implementation libs.spring.context
     implementation libs.spring.core
     implementation libs.slf4j.api
-    implementation libs.logback.classic
+    implementation libs.logback.classic.report
     testImplementation libs.jupiter.core
     testImplementation libs.mockito.core
 }