Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor display glitch when a context attribute has an empty value #12

Open
antoineco opened this issue May 21, 2021 · 3 comments
Open

Minor display glitch when a context attribute has an empty value #12

antoineco opened this issue May 21, 2021 · 3 comments

Comments

@antoineco
Copy link
Contributor

antoineco commented May 21, 2021

Notice how knativeerrordata is displayed with the following CloudEvent:

{"data":"riing riiiing","datacontenttype":"text/plain","id":"f9fd6871-40fe-4a91-b252-d06e5ce3c962","knativeerrorcode":"500","knativeerrordata":"","source":"/apis/v1/namespaces/antoineco/pingsources/pong","specversion":"1.0","time":"2021-05-21T14:59:00.394219291Z","type":"dev.knative.sources.ping"}

image

knativeerrordata list item:

<li>
  <div class="MuiFormControl-root MuiTextField-root jss31 jss29 MuiFormControl-fullWidth">
    <label class="MuiFormLabel-root MuiInputLabel-root MuiInputLabel-formControl MuiInputLabel-animated" data-shrink="false">knativeerrordata</label>
    <div class="MuiInputBase-root MuiInput-root MuiInput-underline MuiInputBase-fullWidth MuiInput-fullWidth MuiInputBase-formControl MuiInput-formControl"><input aria-invalid="false" type="text" class="MuiInputBase-input MuiInput-input" value="">
    </div>
  </div>
</li>

for comparison, knativeerrorcode list item:

<li>
  <div class="MuiFormControl-root MuiTextField-root jss31 jss29 MuiFormControl-fullWidth">
    <label class="MuiFormLabel-root MuiInputLabel-root MuiInputLabel-formControl MuiInputLabel-animated MuiInputLabel-shrink MuiFormLabel-filled" data-shrink="true">knativeerrorcode</label>
    <div class="MuiInputBase-root MuiInput-root MuiInput-underline MuiInputBase-fullWidth MuiInput-fullWidth MuiInputBase-formControl MuiInput-formControl">
      <input aria-invalid="false" type="text" class="MuiInputBase-input MuiInput-input" value="500">
    </div>
  </div>
</li>
@JeffNeff
Copy link

JeffNeff commented Sep 7, 2021

Im not able to replicate this issue.. I was able to add several headers and they rendered properly.
Screen Shot 2021-09-07 at 3 23 53 PM

@antoineco
Copy link
Contributor Author

@JeffNeff because none of them is empty. If I remember correctly, I was playing with error responses when this happened.

@JeffNeff
Copy link

JeffNeff commented Sep 7, 2021

ahh! missed that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants