Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates New Event Sorting Method #2

Merged
merged 5 commits into from
Sep 15, 2021
Merged

Conversation

JeffNeff
Copy link
Contributor

@JeffNeff JeffNeff commented Sep 7, 2021

Includes an Icon in the top right that swaps incoming events direction. This closes issue #16 in the sockeye repo

New events are now populated at the top. This closes issue #16
@JeffNeff
Copy link
Contributor Author

JeffNeff commented Sep 8, 2021

Screen Shot 2021-09-08 at 2 49 45 PM

Notice the new icon in the top right marked in red. When this icon is clicked the incoming event direction is swapped.

Screen recording displaying functionality -> https://streamable.com/866rx4

@n3wscott
Copy link
Owner

n3wscott commented Sep 9, 2021

with a similar change I was not able to get the lock button to work in a way that was not distracting when the new events stream in. Let me try this out! thanks!!

Copy link
Owner

@n3wscott n3wscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n3wscott
Copy link
Owner

ah shoot, some conflicts from the other PR.

@JeffNeff JeffNeff requested a review from n3wscott September 14, 2021 17:10
@n3wscott n3wscott merged commit 69fbb71 into n3wscott:main Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants