Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-kill strategy for even better cancellation #13

Open
vlsi opened this issue Nov 5, 2020 · 0 comments
Open

Self-kill strategy for even better cancellation #13

vlsi opened this issue Nov 5, 2020 · 0 comments

Comments

@vlsi
Copy link

vlsi commented Nov 5, 2020

Hi,

I evaluate cancel-previous-runs, and it looks like the action does not help much in case jobs take ~10 minutes (which is often the case for Apache Caclite).

I wonder if you have evaluated the following approach:

  1. Make users add "cancellation" job to their workflows
  2. The cancellation job would run in parallel with all the others, and it would fetch PR branch and it would kill the jobs in case the PR branch is updated

In other words, "PR update" can't cancel stale jobs for security reasons, so what if each job verifies once in a while "ok, git fetch, if there are changes, then we terminate in the hope to yield for the newer PR jobs".

Would that work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant