feat!: Add support for TCP #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divagant-martian
requested changes
Aug 18, 2025
Contributor
There was a problem hiding this comment.
This is looking really good, I have some organization nits that will allow us to better work on this in the (near) future, and a small check that needs to be made.
Otherwise, some CI checks have minor failures
- formatting
- version number can be ignored as we handle this on releases (@ramfox can you confirm this?)
- ignore the rest, we'll fix those
Thanks for the contribution!
- Extract functions to decode map requests - Check that the response protocol matches requested protocol
Contributor
Author
|
Thanks for the review! I believe I've addressed all requested changes. Let me know if there's anything else I should change. |
Member
|
To confirm: the semver test is basically there as a reminder to include the |
divagant-martian
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi. I needed TCP for my application so I added a configuration option to open a TCP port.
Breaking Changes
Added a new field to the
Configstruct.Notes & open questions
My router supports NAT-PMP so it would be a good idea for someone to test UPNP and PCP.
Change checklist