Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reset/destroy of workspace thumbnails in overview #180

Open
mzur opened this issue Sep 24, 2021 · 1 comment
Open

Fix reset/destroy of workspace thumbnails in overview #180

mzur opened this issue Sep 24, 2021 · 1 comment
Labels
gnome-42 help wanted Extra attention is needed

Comments

@mzur
Copy link
Owner

mzur commented Sep 24, 2021

The workspace thumbnails in the overview are not reset if the extension is disabled, then enabled again and then "Show workspace grid in overview" is switched off. They still show the wallpaper. They also don't reset if the whole extension is disabled in this case.

@ebeem
Copy link
Collaborator

ebeem commented Dec 16, 2021

I would consider this a feature myself 😁
I wonder why they removed it actually.

This doesn't seem to be a bug in the overriding/restoring part.
The thumbnail boxes just need to be reconstructed as they are kept even after restoring.
I am not sure how we can force GNOME to reconstruct the thumbnail boxes but if you try to add more workspaces (let's say add one row), you will notice the new workspaces added will have no wallpaper.

So we just need to figure out a way to reconstruct the thumbnail boxes here.

restoreOriginalProperties() {
Util.overrideProto(GWorkspaceThumbnail.ThumbnailsBox.prototype, this.originalThumbnailsBox);
}

@mzur mzur added gnome-42 and removed gnome-40 labels May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gnome-42 help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants