-
Notifications
You must be signed in to change notification settings - Fork 20
react: CSS struct escape hatch #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Best thing to do here would be to either submit a PR with the additional attributes you require (modifying the "template") or list them here. We could add an escape hatch, but to be honest doing the "right" thing of adding the attributes explicitly seems better. Particularly as I intend to make these more type-safe. But open to thoughts/opinions on that stance. |
Obviously it would be better of all possibilities were covered in a type-safe manner. |
Fair point; I'd be happy reviewing a PR so we can see how it looks/feels in practice. |
I can add some items as I use them. |
Looks useful: https://meiert.com/en/indices/css-properties/ |
Do I support CSS 3 only? Also is there a ways to set the "initial value" (prob might make the generated js too large)? |
Yes please. And I'd work from the spec where possible; it's the definitive reference. |
Here is my pull request: #71 |
Closing because I created my own bindings: https://github.com/rocketlaunchr/react/ |
@pjebs my apologies, I simply haven't had the time to get round to your various issues and PRs. All the best with your bindings! |
Thank you @myitcv. Your package was an inspiration for my own bindings. |
It would be nice if there was an escape hatch for the
CSS
struct which contains a map.The map would allow us to add custom CSS attributes because it is currently very limiting.
The text was updated successfully, but these errors were encountered: