Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring back the Draw grid V-Space and H-Space #1443

Open
elmjag opened this issue Oct 10, 2024 · 2 comments
Open

bring back the Draw grid V-Space and H-Space #1443

elmjag opened this issue Oct 10, 2024 · 2 comments

Comments

@elmjag
Copy link
Contributor

elmjag commented Oct 10, 2024

The V-Space and H-Space boxes in the Draw grid widget have been removed in this PR: #1397

image

We are actually using these controls. We did tests doing mesh grid scans with H-Space separation last week, and it worked for us.

Can we bring them back?

As I understand, these controls are seldom used, so let's make it configurable if they are shown. I suggest to add these two UI configs:

show_mesh_grid_vspace   true/false
show_mesh_grid_hspace   true/false

With default values set to false for both of them.

As a side note, at MicroMAX currently we only want to show H-Space, but in the future we want to show both. Thus it would be nice to make each box individually configurable.

@marcus-oscarsson
Copy link
Member

We wont have anything against re-introducing the h and v-space controls if you are using them. They where added because we thought there might be a use for h/v space but in the end no one actually used them. Many users also found the controls strange, for some reason, and where mostly just wondering why we had those. The decision was thus to remove them and possibly replace them with something more "user friendly" when actually requested.

It might be necessary to have a second look at these controls when we have some more feedback from the scientists but adding them back as they where would be fine.

@elmjag
Copy link
Contributor Author

elmjag commented Oct 11, 2024

@mockoocy will work on this.

mockoocy pushed a commit to mockoocy/mxcubeweb that referenced this issue Oct 17, 2024
mockoocy pushed a commit to mockoocy/mxcubeweb that referenced this issue Oct 17, 2024
mockoocy pushed a commit to mockoocy/mxcubeweb that referenced this issue Oct 17, 2024
mockoocy pushed a commit to mockoocy/mxcubeweb that referenced this issue Oct 17, 2024
mockoocy pushed a commit to mockoocy/mxcubeweb that referenced this issue Oct 17, 2024
marcus-oscarsson pushed a commit to mockoocy/mxcubeweb that referenced this issue Oct 18, 2024
mockoocy pushed a commit to mockoocy/mxcubeweb that referenced this issue Oct 18, 2024
Restores controls used for setting horizontal and vertical cell spacing
for grid mesh
marcus-oscarsson pushed a commit to mockoocy/mxcubeweb that referenced this issue Oct 18, 2024
Restores controls used for setting horizontal and vertical cell spacing
for grid mesh
marcus-oscarsson pushed a commit to mockoocy/mxcubeweb that referenced this issue Oct 22, 2024
Restores controls used for setting horizontal and vertical cell spacing
for grid mesh
marcus-oscarsson pushed a commit that referenced this issue Oct 22, 2024
Restores controls used for setting horizontal and vertical cell spacing
for grid mesh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants