Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double check impact/opportunities of react-contexify@6 upgrade #1430

Open
axelboc opened this issue Oct 1, 2024 · 3 comments
Open

Double check impact/opportunities of react-contexify@6 upgrade #1430

axelboc opened this issue Oct 1, 2024 · 3 comments

Comments

@axelboc
Copy link
Collaborator

axelboc commented Oct 1, 2024

There are a bunch of changes in v6, including breaking changes (CSS import path, CSS classes, etc.), might be worth doubling checking those. There may also be opportunities to improve/simplify the code with some of the new features, maybe? 🤷 https://github.com/fkhadra/react-contexify/releases/tag/v6.0.0

Originally posted by @axelboc in #1428 (comment)

@marcus-oscarsson
Copy link
Member

By the way, is it a good idea to use a library for the context menus or should we simply create something our self's. It seems like something that should be rather simple ?

@axelboc
Copy link
Collaborator Author

axelboc commented Oct 1, 2024

It would be worth trying to implement one in pure React Bootstrap, as it should be able to handle at least some of the complexities like dynamic positioning, sub menus, accessibility, etc.

@marcus-oscarsson
Copy link
Member

marcus-oscarsson commented Oct 1, 2024

That's what I though I mean, we are not doing anything super fancy with the context menus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants