Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API documentation #4

Open
mwatts15 opened this issue May 24, 2014 · 10 comments
Open

API documentation #4

mwatts15 opened this issue May 24, 2014 · 10 comments

Comments

@mwatts15
Copy link
Owner

  • Method signatures
  • javadoc comments
@mwatts15
Copy link
Owner Author

A flavor of the developing API: http://my-openworm-docs.readthedocs.org/en/latest/api.html

@slarson
Copy link

slarson commented May 30, 2014

Looking nice!

@DickGordonCan
Copy link

Dear Mark,
In:


Example:

v = Quantity("600","um")
c = Cell(lineageName="AB plapaaaap")
c.divisionVolume(v)


"um" should be "(µm)^3". Thanks.
Yours, -Dick Gordon

@VahidGh
Copy link

VahidGh commented Jun 2, 2014

Looking good...
Assuming we will need to support more biological networks (beside neural networks) in order to complete locomotion dynamics, we need to add muscle cell class (or other cell types). so, we could have a more general connection class like this:
Connection(pre: Cell, post:Cell,...)
and inherit other type of connections from this class.

@mwatts15
Copy link
Owner Author

mwatts15 commented Jun 3, 2014

We could generalize the signaling relationship to:

  • a sending population
  • a receiving population
  • the thing sent

On Mon, Jun 2, 2014 at 5:27 AM, Vahid Ghayoomi [email protected]
wrote:

Looking good...
Assuming we will need to support more biological networks (beside neural
networks) in order to complete locomotion dynamics, we need to add muscle
cell class (or other cell types). so, we could have a more general
connection class like this:
Connection(pre: Cell, post:Cell,...)
and inherit other type of connections from this class.


Reply to this email directly or view it on GitHub
#4 (comment).

Cheers,
Mark Watts
Department of Computer Science
University of Texas at Austin

@slarson
Copy link

slarson commented Jun 3, 2014

Based on some comments from today's discussion:

  • Ability to add a DOI / PMID / WormBaseID to Evidence is important
  • Example code should be as close as possible to code that could actually be written once the API is implemented
  • Evidence class should insulate the user from complexities of BibTex even though BibTex is a great choice for the underlying data representation
  • Let's think more about the utility of asserting a triple directly
  • Make sure to clarify that a Relationship is a whole triple (not just a relation i.e. the middle of a triple)

@slarson
Copy link

slarson commented Jun 4, 2014

More comments from today's discussion

  • Let's see if the Quantity class can take in a string with units and parse it. Let's see if we can find a library that does that parsing for us rather than writing it ourselves (may not be the best use of our time)
  • Let's define the Morphology class or drop it in favor of NeuroML Morphology
  • Add in any additional setter methods that are currently implicit if we plan to have them for tracking purposes and so we can make the scope of the API finite.
  • Let's flesh out the Relationship class and let's define the constructor. Specifically what types of objects will you be able to add to a Relationship? Any type?
  • Let's also think about a general way to get Relationship objects that is easy to use and is tightly linked to the methods that get and set data on the major classes of the API

For now let's hold off on the Signaling class but we should save this and come back to it if we have time at the end:

Signaling(sender : Population, receiver : Population, messengerSpecies : Object )


Signaling.sender() : Population
++++++++++++++++++++++++++++++++

Signaling.receiver() : Population
++++++++++++++++++++++++++++++++++

Signaling.messengerSpecies() : Object
+++++++++++++++++++++++++++++++++++++

Signaling(p1,p2,"Glutamate") <-- behind the scenes Connection relationships get created and that means having a way to define if connections are all - to - all or random or some other connection pattern

Let's also leave the Simulation class out for now until we have time perhaps at the end.

@mwatts15
Copy link
Owner Author

mwatts15 commented Jun 6, 2014

I've started written some tests (af5c7ae) based on this one:
Ability to add a DOI / PMID / WormBaseID to Evidence is important

@mwatts15
Copy link
Owner Author

mwatts15 commented Jun 7, 2014

@slarson I have checked off items which I've addressed in the draft API (9fd57fa).
I'll be adding missing stubs and transferring the documentation to code.

@slarson
Copy link

slarson commented Jun 7, 2014

@mwatts15 looking good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants