Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deleted assets: thumbnail flashes before showing error #24

Open
dylanjha opened this issue Oct 5, 2020 · 0 comments
Open

deleted assets: thumbnail flashes before showing error #24

dylanjha opened this issue Oct 5, 2020 · 0 comments

Comments

@dylanjha
Copy link
Collaborator

dylanjha commented Oct 5, 2020

Repro steps

  • upload a video
  • view the video
  • delete the asset from Mux
  • try to view the video
  • see that the thumbnail flashes before showing an error message

thumbnail-flash

Internally, this is what's happening:

  • video player loads with poster= attribute
  • even though the asset is deleted, previously rendered thumbnail images are cached by cdns for a while (days), so the request to load the poster image (thumbnail) succeeds
  • the m3u8 playlist 404s, which triggers the correct error "This video does not exist"

Solution -- maybe there's something better but this is the best idea I have:

  • before rendering the video player do a fetch GET to the m3u8, if it 404s then fallback into the error state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant