Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

player.style media-chrome dependency #96

Open
luwes opened this issue Sep 25, 2024 · 1 comment
Open

player.style media-chrome dependency #96

luwes opened this issue Sep 25, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@luwes
Copy link
Contributor

luwes commented Sep 25, 2024

the media-chrome dependency can cause conflicts if media-chrome is also installed as a direct dep in your project.
for example in mux-player this is now the case. it's fine at the moment because the major versions are both the same.

solution 1:
make media-chrome a peer dependency
downside is that it's less clean, requires an extra media-chrome, media-chrome/menu, media-chrome/media-theme-element import

solution 2:
document this clearly and document a workaround when a conflict happens.
https://docs.npmjs.com/cli/v9/configuring-npm/package-json#overrides

@luwes luwes added the documentation Improvements or additions to documentation label Jan 29, 2025
@luwes
Copy link
Contributor Author

luwes commented Jan 29, 2025

we have to go with solution 2 here I think. seems this will work for the majority and is easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant