Skip to content

Commit 0b90bd0

Browse files
authored
fix: upgrade media-chrome 1.4.5 + rate row style (#803)
![SCR-20231027-nq0](https://github.com/muxinc/elements/assets/360826/c6145588-2ae8-4606-8e2c-f5cb86a76f00)
1 parent 662cd52 commit 0b90bd0

File tree

3 files changed

+27
-28
lines changed

3 files changed

+27
-28
lines changed

packages/mux-player/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@
9696
"dependencies": {
9797
"@mux/mux-video": "0.17.0",
9898
"@mux/playback-core": "0.21.0",
99-
"media-chrome": "^1.4.3"
99+
"media-chrome": "^1.4.5"
100100
},
101101
"devDependencies": {
102102
"@mux/esbuilder": "0.1.0",

packages/mux-player/src/themes/gerwig/gerwig.html

Lines changed: 22 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,27 @@
179179
--media-control-height: 16px;
180180
}
181181

182+
media-playback-rate-button {
183+
--media-control-padding: 6px 3px;
184+
min-width: 4.4ch;
185+
}
186+
187+
media-playback-rate-listbox {
188+
--media-listbox-layout: row;
189+
--media-option-selected-background: var(--_accent-color);
190+
margin-right: 6px;
191+
padding: 0;
192+
}
193+
194+
media-playback-rate-listbox::part(option) {
195+
padding: 8px 4px;
196+
}
197+
198+
media-playback-rate-listbox::part(option-selected) {
199+
color: #fff;
200+
opacity: 0.6;
201+
}
202+
182203
:host(:not([audio])) media-time-range {
183204
--media-range-padding: 0;
184205
background: transparent;
@@ -728,29 +749,7 @@
728749
aria-disabled="{{disabled}}"
729750
>
730751
<media-playback-rate-button slot="button" part="bottom playback-rate button"></media-playback-rate-button>
731-
<media-playback-rate-listbox slot="listbox" part="bottom playback-rate listbox">
732-
<div slot="select-indicator">
733-
<style>
734-
.listbox-indicator {
735-
position: relative;
736-
top: 1px;
737-
width: 0.9em;
738-
height: auto;
739-
fill: var(--_accent-color);
740-
}
741-
742-
[aria-selected='false'] .listbox-indicator {
743-
display: none;
744-
}
745-
</style>
746-
<svg viewBox="0 0 14 18" class="listbox-indicator">
747-
<path
748-
d="M12.252 3.48c-.115.033-.301.161-.425.291-.059.063-1.407 1.815-2.995 3.894s-2.897 3.79-2.908 3.802c-.013.014-.661-.616-1.672-1.624-.908-.905-1.702-1.681-1.765-1.723-.401-.27-.783-.211-1.176.183a1.285 1.285 0 0 0-.261.342.582.582 0 0 0-.082.35c0 .165.01.205.08.35.075.153.213.296 2.182 2.271 1.156 1.159 2.17 2.159 2.253 2.222.189.143.338.196.539.194.203-.003.412-.104.618-.299.205-.193 6.7-8.693 6.804-8.903a.716.716 0 0 0 .085-.345c.01-.179.005-.203-.062-.339-.124-.252-.45-.531-.746-.639a.784.784 0 0 0-.469-.027"
749-
fill-rule="evenodd"
750-
/>
751-
</svg>
752-
</div>
753-
</media-playback-rate-listbox>
752+
<media-playback-rate-listbox slot="listbox" part="bottom playback-rate listbox"></media-playback-rate-listbox>
754753
</media-playback-rate-selectmenu>
755754
</template>
756755

yarn.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10672,10 +10672,10 @@ [email protected]:
1067210672
resolved "https://registry.yarnpkg.com/mdn-data/-/mdn-data-2.0.4.tgz#699b3c38ac6f1d728091a64650b65d388502fd5b"
1067310673
integrity sha512-iV3XNKw06j5Q7mi6h+9vbx23Tv7JkjEVgKHW4pimwyDGWm0OIQntJJ+u1C6mg6mK1EaTv42XQ7w76yuzH7M2cA==
1067410674

10675-
media-chrome@^1.4.3:
10676-
version "1.4.3"
10677-
resolved "https://registry.yarnpkg.com/media-chrome/-/media-chrome-1.4.3.tgz#133564991d33eb3a5d9eeaa2d3208250392e5590"
10678-
integrity sha512-VpFqCOu2FLULW6TX4sluo44AolJXryHxr85UBdO+IuOltgYPuf7Lgp1F3OqJeRIeO8874d5mri/6xmI22CO9yA==
10675+
media-chrome@^1.4.5:
10676+
version "1.4.5"
10677+
resolved "https://registry.yarnpkg.com/media-chrome/-/media-chrome-1.4.5.tgz#8c21d5bab395697437c61f1acfd2f083cb07c28b"
10678+
integrity sha512-WRi+4XV4oCx8nwUEhhKxqF78mdQDVTPHgq2g/Mkt8C8lmIaca9WwnahZ0MHx8fy8XAEaiIv1B25555lpvZncJQ==
1067910679

1068010680
[email protected], media-tracks@>=0.2.3:
1068110681
version "0.2.3"

0 commit comments

Comments
 (0)