You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As I was reading through the source code, I've listed some minor issues which may improve the project:
Route guards (Currently we can move to the login page by typing the address in the URL bar even when we are already logged in)
mapValidationResponse does not handle 403 error
No need to write <template #default> for suspense
Enforce an import order convention
Reset errors when re-submitting the forms
useArticles composable:
6.1. In fetchArticles function, since articleType can only have one value, it's better to use if-else rather than only if to skip other checks.
6.2 getArticlesMeta function is acting like a composable. So maybe it's better to rename it to useArticlesMeta
Vue docs doesn't recommend using generic argument for reactive(). So it may be better to change current generic usage.
In AppLink component, useAttrs and v-bind="attrs" can be removed because of Fallthrough Attributes
Add "Not Found" page
I would like to help fix these issues if they are valid to you. :D
The text was updated successfully, but these errors were encountered:
Some of the content of this repository may seem less appropriate with Vue's update, and some of your suggestions are fine. My focus is not on Vue for the time being, if you can, PR welcome!
In AppLink component, useAttrs and v-bind="attrs" can be removed because of Fallthrough Attributes
I think it is not a good idea to do this. This will lose the type of the component props. If IDE or VLS can deduce the type of the component's root element, I think it makes sense to do so, and until then, I don't think it's good practice.
As I was reading through the source code, I've listed some minor issues which may improve the project:
mapValidationResponse
does not handle403
error<template #default>
for suspenseuseArticles
composable:6.1. In
fetchArticles
function, sincearticleType
can only have one value, it's better to useif-else
rather than onlyif
to skip other checks.6.2
getArticlesMeta
function is acting like a composable. So maybe it's better to rename it touseArticlesMeta
reactive()
. So it may be better to change current generic usage.AppLink
component,useAttrs
andv-bind="attrs"
can be removed because of Fallthrough AttributesI would like to help fix these issues if they are valid to you. :D
The text was updated successfully, but these errors were encountered: