Sirius XM - Can't update credentials after entering a bad password

[smartypants1138]

What version of Music Assistant has the issue?

2.3.2

What version of the Home Assistant Integration have you got installed?

2024.11.0

Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

• Yes

The problem

I attempted to add the Sirius XM integration, unfortunately, I provided the wrong password. But, I don't see the integration in MA. When I attempt to Add SXM again, I see this message; Provider siriusxm already loaded and only one instance allowed

How to reproduce

I attempted to add the Sirius XM integration, unfortunately, I provided the wrong password. But, I don't see the integration in MA. When I attempt to Add SXM again, I see this message: "Provider siriusxm already loaded and only one instance allowed"

Music Providers

SiriusXM

Player Providers

N/A

MA Log File.txt

[OzGav]

Pleas edit your post and remove the pasted log entry and attach it as a file.

[smartypants1138]

Done, the Download logfile link doesn't provide a way to save the file as specific time, so I saved everything as a txt file.

[OzGav]

@btoconnor

[btoconnor]

I'll take a look in the next few days, but my initial read here is that this isn't a SiriusXM integration issue, but rather a settings issue?

My read here is that if someone puts in a bad username / password combo, MA is registering that this integration is setup, but it's not actually allowing configuration in the settings. Because this integration was not setup as multi-instance, then users are not allowed to edit it. I'm not entirely sure what the provider is supposed to do here - the code is raising the LoginFailed exception if it can't authenticate.

Happy to be corrected though and update the provider if something here needs to change.

[OzGav]

Spotify has a CLEAR AUTHENTICATION button so you can start again

[btoconnor]

I'll play around with the integration this weekend by putting in some bad credentials, but my understanding was that the integration isn't even showing up right now to edit?

[smartypants1138]

That's correct, the configuration isn't showing up to edit. Sent via the Samsung Galaxy S22 Ultra 5G, an AT&T 5G smartphone Get Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: btoconnor ***@***.***> Sent: Tuesday, November 5, 2024 8:16:47 AM To: music-assistant/hass-music-assistant ***@***.***> Cc: Jeff Geller ***@***.***>; Author ***@***.***> Subject: Re: [music-assistant/hass-music-assistant] Sirius XM - Can't update credentials after entering a bad password (Issue #3127) I'll play around with the integration this weekend by putting in some bad credentials, but my understanding was that the integration isn't even showing up right now to edit? — Reply to this email directly, view it on GitHub<#3127 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AJSD73C5KVLMX5DAURYF25TZ7DONPAVCNFSM6AAAAABRESGKXCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJXGQ2DINBRHA>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[OzGav]

@btoconnor getting a few more reports about this…

[btoconnor]

EDIT: Nevermind - I think I might have found the issue. I'll take another look this weekend.

It's not clear to me what the fix here is, or if this should be handled in the SiriusXM player provider or the MA core.

If someone adds bad credentials, and then the player disappears from MA, this sounds to me like an issue with the MA core. I can recreate that adding bad credentials to the MA and it fails in a spinning loop to add it. The code is currently correctly raising LoginFailed when bad credentials are added, and I don't see any other providers handling that exception.

There's no button that I can provide on the settings page that will clear authentication, because the integration isn't showing up. If there's a different error besides LoginFailed that I can throw to make it so that this is editable, I'm happy to adjust it.

I would expect if an Exception is raised during the call to handle_async_init(...), that MA would handle this and not register the music player as registered, which is the issue here AFAICT.