Favorite songs should like their backend service

[eimirae]

When favoriting a song, the song provider should also like the song (if available).
I'm not sure how to handle when a song is available on multiple providers? Perhaps favorite them all?

Ideally, also, make favorite buttons available on the player.

Thanks for considering this!

[OzGav]

That should already be happening. What provider did you use?

[eimirae]

Hi, sorry for the late response,

I'm using ytmusic.

I've been searching around the source code,

I believe the function used within the ytmusicapi would be rate_song: https://ytmusicapi.readthedocs.io/en/stable/reference.html#ytmusicapi.YTMusic.rate_song

but searching in the source code for the helpers and ytmusic provider, I can find rate_playlist references: https://github.com/music-assistant/server/blob/bf9b16dc61c558bf784f6e13a55cf6e5eecff7c4/music_assistant/server/providers/ytmusic/helpers.py#L179

But no rate_song function calls.

This matches my experience of using the program, where I can like a playlist and see that reflected within youtube, but liking a song does not cause youtube to have a corresponding like.

[OzGav]

@MarvinSchenkel ?

[MarvinSchenkel]

Sounds like something I missed! Could you make an issue with this request so I can assign it to myself?

[OzGav]

I’ll push it to an issue from here

[eimirae]

First off all, thanks for this integration, its great.

Second of all, I did some digging on what is happening, and here is what I found if it is helpful at all.

https://github.com/music-assistant/server/blob/bf9b16dc61c558bf784f6e13a55cf6e5eecff7c4/music_assistant/server/controllers/music.py#L437
Indicates that LIBRARY_TRACKS_EDIT feature is needed, which might possibly be a deeper can of worms for other functions behavior based on this feature.

[MarvinSchenkel]

It's basically the other way around. Adding that feature indicates to MA that the provider supports adding tracks to the remote library. I just need to implement it for YTM.