Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend recipe development #26

Open
mcartmel opened this issue Apr 17, 2018 · 6 comments
Open

Frontend recipe development #26

mcartmel opened this issue Apr 17, 2018 · 6 comments

Comments

@mcartmel
Copy link
Contributor

mcartmel commented Apr 17, 2018

The following issues have been addressed in the latest update:

  • (1) <link url='...'> does not support any internal text so instead a massive title has to be used
  • (2a) A light-weight "field name/ field value" UI element bound to an event/signal is not supported. Instead a very heavy <panel> has to be used.
    • in this example, it'd be nice to have those basic text fields presented elegantly (Firmware, Run Mode, Device Error Status
  • (3) How do you layout a bank of range controls elegantly (spacing an issue; and an index label would be nice)?
  • (4) <range> is missing the current value, a bit like how the meters have (shown)
  • (5) How to you layout a bank of On/Off switches elegantly (an index label would be nice)?
  • (6) <meter> only support 0-100. I'd say standardise on typical dB audio range of -60dB to +6dB.
  • (7) Natively supporting a bump on <range> would be very useful. So + and - or and
@mcartmel
Copy link
Contributor Author

@scroix @justparking Please feel free to comment on the latest updates. Examples have been added to the index-sample.xml.

@scroix
Copy link
Member

scroix commented Apr 17, 2018

@mcartmel looking good!

The improved range (widget, instrument, doodad) and link names are perfect.

newrange

I'm in the same camp for the much needed field label too, but I'm getting a .not-allowed {cursor: not-allowed;} cursor on hover.

testingfield

The support for db on the meters is great, especially considering the new XMV recipe. I just couldn't seem to see any provisions for specifying a custom range (other than 0 - 100, or 'db') and wondered if this was a consideration?

I couldn't discover or manage to test (5) or (7) .

@mcartmel
Copy link
Contributor Author

Yes sorry, 5 & 7 not yet addressed.

I added a specific dB handler because it's handled logarithmically. I guess I could always just allow a custom range to be set for a linear scale, if you think that would be useful?

I was a bit unsure how to handle the single value field. In the end I decided to make it a regular HTML input, but since it doesn't support triggering an action I added the 'disabled' state. I guess you would actually want it enabled for selection, but remain disabled for editing?

@mcartmel
Copy link
Contributor Author

@scroix Switched to using readonly instead of disabled on the field so you can select the text.

@mcartmel
Copy link
Contributor Author

Regarding (3), margin was added to the bottom of the range control so they will space themselves when stacked. Arrangement can be managed through the use of columns and rows.

@scroix
Copy link
Member

scroix commented May 2, 2018

Awesome!

To answer your earlier question, I'm a big fan of supporting a custom range for linear scales. I've come across volume scales that range from 0 - 127, or 158, I can't explain why... There's also the case of measuring Celsius, or more obscure, Hz, Fan RPM, Disk Space etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants