Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog opening should never dismiss tour popups #26341

Open
4 tasks done
avvvvve opened this issue Feb 5, 2025 · 0 comments
Open
4 tasks done

Dialog opening should never dismiss tour popups #26341

avvvvve opened this issue Feb 5, 2025 · 0 comments
Assignees
Labels
P1 Priority: High Pre-release feature issue This pertains to a new feature and should be addressed prior to release UX/interaction

Comments

@avvvvve
Copy link

avvvvve commented Feb 5, 2025

Related to #26282 which introduced the tours system.

Bug

See video. After the new tour popup appears, the announcement dialog appears seconds later and in doing so, takes focus away from the main app window which dismisses the tour popup.

Screen.Recording.2025-02-04.at.10.05.05.AM.mov

Solution

The tour popup should not be dismissed when focus is moved away from the main app window. They should also not be dismissed when clicking outside of them.

Other types of popups can still be dismissed the ways above, but tours specifically must only be dismissed when the user either:

  • clicks the buttons that closes it (in this case, "Got it") OR
  • clicks one of the note input buttons

(It should probably stay open when 'Watch video' is clicked)

FYI @bkunda - want to make sure you're good with the approach above!

What is the latest version of MuseScore Studio where this issue is present?

Nightly

Regression

No.

Operating system

macOS 15

Checklist

  • This report follows the guidelines for reporting bugs and issues
  • I have verified that this issue has not been logged before, by searching the issue tracker for similar issues
  • I have attached all requested files and information to this report
  • I have attempted to identify the root problem as concisely as possible, and have used minimal reproducible examples where possible
@avvvvve avvvvve added P1 Priority: High Pre-release feature issue This pertains to a new feature and should be addressed prior to release UX/interaction labels Feb 5, 2025
@avvvvve avvvvve moved this to To do in MuseScore Studio 4.5 Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Priority: High Pre-release feature issue This pertains to a new feature and should be addressed prior to release UX/interaction
Projects
Status: To do
Development

No branches or pull requests

2 participants