11565: Skip onChanged notifications when resetting preferences for settings who have their default values

krasko78 · krasko78 · commit 3397c58394b8 · 2025-01-12T00:30:48.000+01:00
diff --git a/src/framework/global/settings.cpp b/src/framework/global/settings.cpp
@@ -114,6 +114,10 @@ void Settings::reset(bool keepDefaultSettings, bool notifyAboutChanges)
     }
 
     for (auto it = m_items.begin(); it != m_items.end(); ++it) {
+        if (it->second.value == it->second.defaultValue) {
+            continue;
+        }
+
         it->second.value = it->second.defaultValue;
 
         Channel<Val>& channel = findChannel(it->first);

Original file line number	Diff line number	Diff line change
`@@ -114,6 +114,10 @@ void Settings::reset(bool keepDefaultSettings, bool notifyAboutChanges)`
`114`	`114`	`}`
`115`	`115`
`116`	`116`	`for (auto it = m_items.begin(); it != m_items.end(); ++it) {`
	`117`	`+ if (it->second.value == it->second.defaultValue) {`
	`118`	`+ continue;`
	`119`	`+ }`
	`120`	`+`
`117`	`121`	`it->second.value = it->second.defaultValue;`
`118`	`122`
`119`	`123`	`Channel<Val>& channel = findChannel(it->first);`