Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrdinaryCallingFormat returns None in s3.lookup() #30

Open
jvivian opened this issue Mar 25, 2016 · 0 comments
Open

OrdinaryCallingFormat returns None in s3.lookup() #30

jvivian opened this issue Mar 25, 2016 · 0 comments

Comments

@jvivian
Copy link

jvivian commented Mar 25, 2016

Hey there,

In s3-multipart-download.py you repeat the connect_s3() call
https://github.com/mumrah/s3-multipart/blob/master/s3-mp-download.py#L110-L113

which causes this to happen:

DEBUG:s3-mp-download:CLI args: Namespace(dest='./test', force=False, max_tries=5, num_processes=2, quiet=False, secure=True, split=32, src='s3://cgl-driver-projects/test/test', verbose=True)
DEBUG:s3-mp-download:split_rs: SplitResult(scheme='s3', netloc='cgl-driver-projects', path='/test/test', query='', fragment='')
Traceback (most recent call last):
  File "../../s3-multipart/s3-mp-download.py", line 170, in <module>
    main(**arg_dict)
  File "../../s3-multipart/s3-mp-download.py", line 115, in main
    raise ValueError("'%s' is not a valid bucket" % split_rs.netloc)
ValueError: 'cgl-driver-projects' is not a valid bucket

If i remove the OrdinaryCallingFormat() call, which I know let's you select buckets with dots, then it works no problem.

Unrelated, and I think this may be a boto issue, but https://github.com/mumrah/s3-multipart/blob/master/s3-mp-download.py#L116 fails if I don't provide a src that has an extension. e.g. s3://bucket/test/test fails, but s3://bucket/test/test.txt succeeds.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant