Build error on 32-bit architecture due to missing static_casts

[VVD]

Description

Build error on i386 (ia32):

/wrkdirs/usr/ports/audio/mumble-server/work/mumble-1.5.613/src/MumbleProtocol.cpp:784:57: error: implicit conversion loses integer precision: 'std::uint64_t' (aka 'unsigned long long') to 'size_type' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
  784 |                 m_audioData.payload = gsl::span< byte >(payloadBegin, payloadSize);
      |                                       ~~~                             ^~~~~~~~~~~

/wrkdirs/usr/ports/audio/mumble-server/work/mumble-1.5.613/src/murmur/Server.cpp:1044:21: error: implicit conversion changes signedness: 'int' to 'std::vector<char>::size_type' (aka 'unsigned int') [-Werror,-Wsign-conversion]
                bufVec.resize(len + 4);
                       ~~~~~~ ~~~~^~~
1 error generated.

/wrkdirs/usr/ports/audio/mumble/work/mumble-1.5.613/src/mumble/Audio.cpp:46:25: error: implicit conversion loses integer precision: 'qint64' (aka 'long long') to 'long' [-Werror,-Wshorten-64-to-32]
   46 |                 long time = qetTicker.elapsed();
      |                      ~~~~   ~~~~~~~~~~^~~~~~~~~
1 error generated.

/wrkdirs/usr/ports/audio/mumble/work/mumble-1.5.613/src/mumble/AudioOutput.cpp:620:16: error: implicit conversion changes signedness: 'unsigned int' to 'std::ptrdiff_t' (aka 'int') [-Werror,-Wsign-conversion]
  620 |                                                         recbuff[i] += (pfBuffer[2 * i] / 2.0f + pfBuffer[2 * i + 1] / 2.0f) * volumeAdjustment;
      |                                                         ~~~~~~~ ^
/wrkdirs/usr/ports/audio/mumble/work/mumble-1.5.613/src/mumble/AudioOutput.cpp:624:16: error: implicit conversion changes signedness: 'unsigned int' to 'std::ptrdiff_t' (aka 'int') [-Werror,-Wsign-conversion]
  624 |                                                         recbuff[i] += pfBuffer[i] * volumeAdjustment;
      |                                                         ~~~~~~~ ^
2 errors generated.

FreeBSD 13.2, 13.3, 14.0, 15-CURRENT (main branch).

Steps to reproduce

1. Build mumble

Mumble version

1.5.613

Mumble component

Both

OS

FreeBSD

Reproducible?

Yes

Additional information

No response

Relevant log output

No response

Screenshots

No response

[VVD]

1st error fixed with patch:

--- src/MumbleProtocol.cpp.orig 2024-03-03 17:26:27 UTC
+++ src/MumbleProtocol.cpp
@@ -781,7 +781,7 @@ namespace Protocol {
                }


-               m_audioData.payload = gsl::span< byte >(payloadBegin, payloadSize);
+               m_audioData.payload = gsl::span< byte >(payloadBegin, static_cast< size_t >(payloadSize));

                if (stream.left() == 3 * sizeof(float)) {
                        // If there are further bytes after the audio payload, this means that there is positional data attached to

[VVD]

2nd error fixed with patch:

--- src/murmur/Server.cpp.orig  2024-03-03 17:26:27 UTC
+++ src/murmur/Server.cpp
@@ -1041,7 +1041,7 @@ void Server::sendMessage(ServerUser &u, const unsigned
                        ((reinterpret_cast< quint64 >(ebuffer.data()) + 8) & static_cast< quint64 >(~7)) + 4);
 #else
                std::vector< char > bufVec;
-               bufVec.resize(len + 4);
+               bufVec.resize(static_cast< std::size_t >(len + 4));
                char *buffer    = bufVec.data();
 #endif
                {

[VVD]

3rd:

--- src/mumble/Audio.cpp.orig   2024-03-03 17:26:27 UTC
+++ src/mumble/Audio.cpp
@@ -43,7 +43,7 @@ void LoopUser::addFrame(const Mumble::Protocol::AudioD
                QMutexLocker l(&qmLock);
                bool restart = (qetLastFetch.elapsed() > 100);

-               long time = qetTicker.elapsed();
+               long long time = qetTicker.elapsed();

                float r;
                if (restart)

4th:

--- src/mumble/AudioOutput.cpp.orig     2024-03-03 17:26:27 UTC
+++ src/mumble/AudioOutput.cpp
@@ -617,11 +617,11 @@ bool AudioOutput::mix(void *outbuff, unsigned int fram
                                                // Mix down stereo to mono. TODO: stereo record support
                                                // frame: for a stereo stream, the [LR] pair inside ...[LR]LRLRLR.... is a frame
                                                for (unsigned int i = 0; i < frameCount; ++i) {
-                                                       recbuff[i] += (pfBuffer[2 * i] / 2.0f + pfBuffer[2 * i + 1] / 2.0f) * volumeAdjustment;
+                                                       recbuff[static_cast< int >(i)] += (pfBuffer[2 * i] / 2.0f + pfBuffer[2 * i + 1] / 2.0f) * volumeAdjustment;
                                                }
                                        } else {
                                                for (unsigned int i = 0; i < frameCount; ++i) {
-                                                       recbuff[i] += pfBuffer[i] * volumeAdjustment;
+                                                       recbuff[static_cast< int >(i)] += pfBuffer[i] * volumeAdjustment;
                                                }
                                        }
 

or

--- src/mumble/AudioOutput.cpp.orig     2024-03-03 17:26:27 UTC
+++ src/mumble/AudioOutput.cpp
@@ -616,11 +616,11 @@ bool AudioOutput::mix(void *outbuff, unsigned int fram
                                        if (speech->bStereo) {
                                                // Mix down stereo to mono. TODO: stereo record support
                                                // frame: for a stereo stream, the [LR] pair inside ...[LR]LRLRLR.... is a frame
-                                               for (unsigned int i = 0; i < frameCount; ++i) {
+                                               for (int i = 0; i < frameCount; ++i) {
                                                        recbuff[i] += (pfBuffer[2 * i] / 2.0f + pfBuffer[2 * i + 1] / 2.0f) * volumeAdjustment;
                                                }
                                        } else {
-                                               for (unsigned int i = 0; i < frameCount; ++i) {
+                                               for (int i = 0; i < frameCount; ++i) {
                                                        recbuff[i] += pfBuffer[i] * volumeAdjustment;
                                                }
                                        }

[Krzmbrzl]

Please submit a PR with your patches. The first patch should cast to std::size_t though, I think.

For a quick workaround you can also run cmake with -Dwarnings-as-errors=OFF.

[VVD]

Maybe you know how to create pool request from file with patch without fork the repo?

[Krzmbrzl]

Forking the repo is the correct (and only) way.

[VVD]

I don't want create personal fork for "oneliners".

[Krzmbrzl]

It's literally free and it's the only way to create PRs for people without write access to the main repo. You can even do everything from the Browser. If you click on the edit button in a file, the fork will be created automatically in the process of changing the file.

[kingbeowulf]

Just updated Slackbuild.org build scripts for mumble-1.5.634 (I'm the build script maintainer). Looks like only the first and second pop up here for Slackware32-15.0 (mumble-server). Since my server is x86_64, and the x86-32 server seems to run ok, I'll just use -Dwarnings-as-errors=OFF for now as a work around on Slackbuilds.org until the mumble devs figure out how they want to go about fixing this "warnings as errors" protocol.

[Kladki]

Doesn't seem to be entirely fixed, still needs this to become qint64

mumble/src/murmur/ServerUser.h

Line 89 in 7d920e7

long m_currentTokens;

[Krzmbrzl]

Unfortunately, that log is no longer available (next time it would be better if you posted the relevant error/warning message here). Since we want to reduce using Qt-specific types in Mumble code, making m_currentTokens a qint64 variable is not an option.
I hope #6694 resolves the issue you have observed.