Master volume restart bug

[NetroX1993]

Describe the bug

When playing MTA i often lower the Master volume because i sometimes listen to music or have some videos playing in the background.

Like this:

It's working as intended. But when i restart the client it looks like this:

The radio volume and the SFX volume has been lowered for some reason which makes the sounds quieter than before the restart.

Steps to reproduce

1. Lower Master volume in settings
2. Restart client
3. Radio volume and SFX volume has now the same level or even lower than Master volume

Version

Client: Multi Theft Auto v1.6-release-23952 (Windows11, 64 Bit)

Additional context

No response

Relevant log output

Security Policy

• I have read and understood the Security Policy and this issue is not security related.

[Kinimel]

I've been through this before and I remember reporting it once thinking it was a bug, but the only answer I got was to leave the volume set to 100%.

[FileEX]

I’m not sure if this is a bug, since it’s an intentional change in the code.

void CSettings::SetRadioVolume(float fVolume)
{
    fVolume = std::max(0.0f, std::min(fVolume, 1.0f));

    m_fRadioVolume = fVolume;

    CCore::GetSingleton().GetGame()->GetSettings()->SetRadioVolume(m_fRadioVolume * CVARS_GET_VALUE<float>("mastervolume") * 64.0f);
}

void CSettings::SetSFXVolume(float fVolume)
{
    fVolume = std::max(0.0f, std::min(fVolume, 1.0f));

    m_fSFXVolume = fVolume;

    CCore::GetSingleton().GetGame()->GetSettings()->SetSFXVolume(m_fSFXVolume * CVARS_GET_VALUE<float>("mastervolume") * 64.0f);
}

I think we should update the SFX and radio volume when changing the master volume to eliminate this inconsistency.

[ArranTuna]

I've been affected by this for I don't know how long but as I didn't know what action would cause it be lowered, never reported it so yes I can confirm this is a bug and it bugs me. My SFX volume is being constantly lowered by something and wow it's as simple as checking SFX volume, then quitting the game. I checked it and it said 34%, restarted MTA and now it says 10%.

After restart:

After a second restart:

Explains why my game always ended up with no volume.

[FileEX]

Fixed in b8c7b90