Skip to content

Commit 6619ef8

Browse files
committed
fix: SessionRecorder usage
1 parent f5b80ff commit 6619ef8

File tree

2 files changed

+8
-44
lines changed

2 files changed

+8
-44
lines changed

README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,9 @@ Session session = new Session();
3737
session.setName("My Session");
3838

3939
// Add tags if needed
40-
session.addTag("environment", "production");
41-
session.addTag("version", "1.0.0");
40+
session.addTag("production");
41+
session.addTag("v1.0.0");
42+
session.addTag("feature:session-recording");
4243

4344
SessionRecorder.start(SessionType.PLAIN, session);
4445
```

src/main/java/app/multiplayer/session_recorder/type/Session.java

Lines changed: 5 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public class Session {
1212
private Map<String, Object> resourceAttributes;
1313
private Map<String, Object> sessionAttributes;
1414

15-
private List<Tag> tags = new ArrayList<>();
15+
private List<String> tags = new ArrayList<>();
1616

1717
// --- Getters and Setters ---
1818

@@ -56,58 +56,21 @@ public void setSessionAttributes(Map<String, Object> sessionAttributes) {
5656
this.sessionAttributes = sessionAttributes;
5757
}
5858

59-
public List<Tag> getTags() {
59+
public List<String> getTags() {
6060
return tags;
6161
}
6262

63-
public void setTags(List<Tag> tags) {
63+
public void setTags(List<String> tags) {
6464
this.tags = tags;
6565
}
6666

6767
/**
6868
* Add a tag to the session
69-
* @param key the tag key
70-
* @param value the tag value
69+
* @param tag the tag string to add
7170
*/
72-
public void addTag(String key, String value) {
73-
this.tags.add(new Tag(key, value));
74-
}
75-
76-
/**
77-
* Add a tag to the session
78-
* @param tag the tag to add
79-
*/
80-
public void addTag(Tag tag) {
71+
public void addTag(String tag) {
8172
this.tags.add(tag);
8273
}
8374

84-
// --- Inner class for Tag ---
85-
86-
public static class Tag {
87-
private String key;
88-
private String value;
8975

90-
public Tag() {}
91-
92-
public Tag(String key, String value) {
93-
this.key = key;
94-
this.value = value;
95-
}
96-
97-
public String getKey() {
98-
return key;
99-
}
100-
101-
public void setKey(String key) {
102-
this.key = key;
103-
}
104-
105-
public String getValue() {
106-
return value;
107-
}
108-
109-
public void setValue(String value) {
110-
this.value = value;
111-
}
112-
}
11376
}

0 commit comments

Comments
 (0)