Update bindings and address issues with net interface type #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pronebird
changed the title
dlon
approved these changes
Nov 20, 2023
dlon
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
pronebird
commented
Nov 27, 2023
There was a problem hiding this comment.
@dlon personally I think it's not necessary to keep IrDA as I don't think there are any devices around that support infra red.
However note that the "bridge" interface was made private and I think it shows up in the list of interfaces. Perhaps introducing SCNetworkInterfaceType::Other(String) could be the way to go to enable parsing of unknown interfaces.
Reviewable status:
… types into separate string constants
dlon
force-pushed
the
update-bindings
branch
from
c3d6ffb
to
3f2dcab
Compare
This was referenced Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates bindings and moves Bridge and IrDA types to static variables since bridge is not defined in public headers and IrDA is deprecated since macOS 12.
This change is