Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML mail is sent as text/plain #5

Open
jri opened this issue Jul 29, 2017 · 2 comments
Open

HTML mail is sent as text/plain #5

jri opened this issue Jul 29, 2017 · 2 comments
Assignees
Labels
Milestone

Comments

@jri
Copy link
Contributor

jri commented Jul 29, 2017

My mail client (OSX Mail) shows the HTML tags contained in the confirmation mail as plain text:

Hi mr. x,<br/><br/>please click the following link to proceed with the sign-up process.<br/><a href="https://domain.com/sign-up/confirm/e65b5023-4249-4181-a388-1964f0a9d841">Kiezatlas Nutzerzugang best&auml;tigen</a><br/><br/>You'll receive another mail once your account is activated by an administrator. This may need 1 or 2 days.<br/><br/>Cheers!

https://domain.com/

I guess this is because text/plain is set as content-type (instead text/html):

------=_Part_18_2102533876.1501317748038
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit

Hi mr. x ...
------=_Part_18_2102533876.1501317748038--

Strange also are the <br/> (instead of <br>) tags, which is XHTML (the proper content-type would be application/xhtml+xml), not HTML.

@jri
Copy link
Contributor Author

jri commented Jul 29, 2017

My suggestion would be to send only plain text mails, not HTML mails.
Usually mail clients render links as clickable by default. HTML is not needed.

@mukil
Copy link
Owner

mukil commented Aug 3, 2017

Indeed this is a regression as sending plain text messages was the default prioir 1.5.2. I guess it has something to do with me utilizing the dm4-sendgrid plugin to send "text/html" (only) mails and I altered the messages in the dm4-sign-up master branch to reflect this change... I will see what I can do as the plugin must support both. Thanks for the hints and your comments!

@mukil mukil self-assigned this Aug 3, 2017
@mukil mukil added the bug label Aug 3, 2017
@mukil mukil added this to the 1.5.3 milestone Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants