Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs Instead of Title for Branding #4341

Open
aress31 opened this issue Oct 30, 2024 · 5 comments
Open

Breadcrumbs Instead of Title for Branding #4341

aress31 opened this issue Oct 30, 2024 · 5 comments
Labels
component: layout This is the name of the generic UI component, not the React module! scope: toolpad-core Abbreviated to "core"

Comments

@aress31
Copy link

aress31 commented Oct 30, 2024

Summary

I would like to use the navigation breadcrumbs in place of a title for branding purposes, as the breadcrumbs are already integrated within the PageContainer and handle all the routing. Is it possible to make them available for the title too? See:

<AppProvider
  theme={theme}
  navigation={navigation}
  branding={{ logo: <Logo/>, title: <Breadcrumb /> }}
>
  <Outlet />
</AppProvider>

The appearance I aim to achieve is:

image

Examples

No response

Motivation

No response

Search keywords: branding breadcrumbs title

@aress31 aress31 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 30, 2024
@apedroferreira
Copy link
Member

apedroferreira commented Nov 1, 2024

A possible solution could be to separate the Breadcrumbs component from the PageContainer so that it could be used in a slot for the title in the header?

@apedroferreira apedroferreira added scope: toolpad-core Abbreviated to "core" and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Nov 1, 2024
@aress31
Copy link
Author

aress31 commented Nov 1, 2024

@apedroferreira, would it also be possible to make the header bar in PageContainer optional? This way, we could achieve a full viewport layout while maintaining a consistent look by wrapping everything within PageContainer or show the page header based on a condition, e.g., activeRoute === whatever.

@apedroferreira
Copy link
Member

apedroferreira commented Nov 1, 2024

@apedroferreira, would it also be possible to make the header bar in PageContainer optional? This way, we could achieve a full viewport layout while maintaining a consistent look by wrapping everything within PageContainer or show the page header based on a condition, e.g., activeRoute === whatever.

I see, I guess we could create a slot for the PageContainer header too.

@Janpot
Copy link
Member

Janpot commented Nov 1, 2024

would it also be possible to make the header bar in PageContainer optional?

Isn't a PageContainer without header just a Container?

@aress31
Copy link
Author

aress31 commented Nov 1, 2024

@Janpot, it might be, but as mentioned, one could want to apply some conditional logic based on route or anything else on hiding/showing the PageContainer bar.

@oliviertassinari oliviertassinari added the component: layout This is the name of the generic UI component, not the React module! label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: layout This is the name of the generic UI component, not the React module! scope: toolpad-core Abbreviated to "core"
Projects
Status: Backlog
Development

No branches or pull requests

4 participants