Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SignInPage] Allow modifying session using setSession #4330

Open
aress31 opened this issue Oct 29, 2024 · 3 comments
Open

[SignInPage] Allow modifying session using setSession #4330

aress31 opened this issue Oct 29, 2024 · 3 comments
Assignees
Labels
scope: toolpad-core Abbreviated to "core"

Comments

@aress31
Copy link

aress31 commented Oct 29, 2024

  • From user pain:

I believe that useSession should return both session and setSession. In many parts of an application, such as the SignInPage, a successful sign-in requires setting the session. Currently, this can only be done at the top level in the AppProvider, forcing the setter to be passed down multiple levels through the component hierarchy. Allowing this hook to both read and update the session directly would significantly expand its usability across various use cases.

@aress31 aress31 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 29, 2024
@bharatkashyap

This comment was marked as outdated.

@bharatkashyap bharatkashyap added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 29, 2024
@aress31

This comment was marked as outdated.

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels Oct 29, 2024
@bharatkashyap

This comment was marked as outdated.

@bharatkashyap bharatkashyap added status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 29, 2024
@bharatkashyap bharatkashyap changed the title SignInPage Not Triggering the AppProvider → Authentication → SignIn Process [SignInPage] Allow modifying session using setSession Oct 30, 2024
@oliviertassinari oliviertassinari added the scope: toolpad-core Abbreviated to "core" label Nov 4, 2024
@bharatkashyap bharatkashyap removed status: waiting for author Issue with insufficient information status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it labels Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: toolpad-core Abbreviated to "core"
Projects
Status: Backlog
Development

No branches or pull requests

3 participants