Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data grid] Remove indeterminateCheckboxAction prop #14300

Open
MBilalShafi opened this issue Aug 23, 2024 · 3 comments · May be fixed by #15522
Open

[data grid] Remove indeterminateCheckboxAction prop #14300

MBilalShafi opened this issue Aug 23, 2024 · 3 comments · May be fixed by #15522
Assignees
@MBilalShafi
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! feature: Selection Related to the data grid Selection feature v8.x

Comments

@MBilalShafi
Copy link
Member

MBilalShafi commented Aug 23, 2024 •
edited
Loading

Remove the prop indeterminateCheckboxAction and make select the default behavior.

Context: #14247 (comment)
@MBilalShafi MBilalShafi mentioned this issue Aug 23, 2024
Open
6 tasks
@github-actions github-actions bot added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Aug 23, 2024
@MBilalShafi MBilalShafi mentioned this issue Aug 23, 2024
Merged
1 task
@MBilalShafi MBilalShafi added breaking change component: data grid This is the name of the generic UI component, not the React module! feature: Selection Related to the data grid Selection feature v8.x and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 23, 2024
@MBilalShafi MBilalShafi changed the title [data grid] Update indeterminateChecboxAction default value [data grid] Update indeterminateCheckboxAction default value Aug 23, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 28, 2024 •
edited
Loading

Do we want to deprecate the indeterminateCheckboxAction prop in v8 and agree on select as the expected behavior?

👍 I think that we should go straight to change the default value and remove the prop in v8. See https://youtu.be/tRsxLLghL1k?si=sRhbVRHVLRR83pMX&t=574. "if you are not adding back at least 10% of what you are removing, you know you are not removing enough".

@MBilalShafi MBilalShafi mentioned this issue Oct 3, 2024
Merged
11 tasks
@MBilalShafi MBilalShafi mentioned this issue Oct 15, 2024
Merged
5 tasks
@oliviertassinari oliviertassinari mentioned this issue Nov 12, 2024
Open
1 task
@MBilalShafi MBilalShafi changed the title [data grid] Update indeterminateCheckboxAction default value [data grid] Remove indeterminateCheckboxAction prop Nov 20, 2024
@marvelsrp
Copy link

I want to draw attention to the erroneous aria-label. It depends on isChecked, but is correctly related by checked.

@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 20, 2024 •
edited
Loading

@marvelsrp Can you open a new issue or a PR? It looks broken indeed, but it's different from this issue. Thanks.

@MBilalShafi MBilalShafi linked a pull request Nov 21, 2024 that will close this issue
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MBilalShafi MBilalShafi

Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! feature: Selection Related to the data grid Selection feature v8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataGrid] Remove indeterminateCheckboxAction prop MBilalShafi/mui-x
3 participants
@marvelsrp @oliviertassinari @MBilalShafi