Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Dialog] maxWidth exceeds in v6 #43636

Closed
joshkel opened this issue Sep 7, 2024 · 1 comment · Fixed by #43626
Closed

[material-ui][Dialog] maxWidth exceeds in v6 #43636

joshkel opened this issue Sep 7, 2024 · 1 comment · Fixed by #43626
Labels
bug 🐛 Something doesn't work component: dialog This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material regression A bug, but worse

Comments

@joshkel
Copy link
Contributor

joshkel commented Sep 7, 2024

Steps to reproduce

Link to live example: https://stackblitz.com/edit/react-koqgrc?file=Demo.tsx

Steps:

  1. Click the button to open the dialog.

Current behavior

The dialog is wider than the available screen space and is not scrollable, even though it's specified maxWidth="sm".

Expected behavior

The dialog should limit itself to the specified maxWidth, and since this content is too wide, it should scroll.

Context

This is a regression in v6 and is the same root cause as #43572 - the overflowY: 'auto' that was removed was also implicitly setting overflowX: 'auto'. Therefore, #43626 should also fix this issue.

Your environment

npx @mui/envinfo
  System:
    OS: macOS 14.6.1
  Binaries:
    Node: 18.20.2 - ~/.nvm/versions/node/v18.20.2/bin/node
    npm: 10.5.0 - ~/.nvm/versions/node/v18.20.2/bin/npm
    pnpm: Not Found
  Browsers:
    Chrome: 128.0.6613.120 (active)
    Edge: 128.0.2739.67
    Safari: 17.6
  npmPackages:
    @emotion/react:  11.13.3
    @emotion/styled:  11.13.0
    @mui/base:  5.0.0-beta.58
    @mui/core-downloads-tracker:  6.0.1
    @mui/icons-material:  6.0.1
    @mui/lab:  6.0.0-beta.8
    @mui/material:  6.0.1
    @mui/private-theming:  6.0.1
    @mui/styled-engine:  6.0.1
    @mui/system:  6.0.1
    @mui/types:  7.2.16
    @mui/utils:  6.0.1
    @mui/x-date-pickers:  7.15.0
    @mui/x-internals:  7.15.0
    @mui/x-tree-view:  7.15.0
    @types/react: ^18.3.5 => 18.3.5
    react: ^18.3.1 => 18.3.1
    react-dom: ^18.3.1 => 18.3.1
    typescript: ^5.5.4 => 5.5.4

Search keywords: Dialog maxWidth

@joshkel joshkel added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Sep 7, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title Dialog maxWidth may be exceeded in v6 [material-ui][Dialog] maxWidth exceeds in v6 Sep 7, 2024
@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work component: dialog This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material regression A bug, but worse and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 7, 2024
Copy link

github-actions bot commented Sep 7, 2024

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

We value your feedback @joshkel! How was your experience with our support team?
If you could spare a moment, we'd love to hear your thoughts in this brief Support Satisfaction survey. Your insights help us improve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: dialog This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material regression A bug, but worse
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants