Skip to content

Commit 463c9f2

Browse files
committed
Rename otherProps
1 parent 8d352ac commit 463c9f2

File tree

3 files changed

+11
-12
lines changed

3 files changed

+11
-12
lines changed

docs/reference/generated/toggle-group.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
},
1313
"onValueChange": {
1414
"type": "function(groupValue: Array<any>, event: Event) => void",
15-
"required": true,
1615
"description": "Callback fired when the pressed states of the ToggleGroup changes."
1716
},
1817
"toggleMultiple": {

packages/react/src/toggle-group/ToggleGroup.tsx

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ const customStyleHookMapping = {
2626
* Documentation: [Base UI Toggle Group](https://base-ui.com/react/components/toggle-group)
2727
*/
2828
const ToggleGroup = React.forwardRef(function ToggleGroup(
29-
props: ToggleGroup.Props,
29+
componentProps: ToggleGroup.Props,
3030
forwardedRef: React.ForwardedRef<HTMLDivElement>,
3131
) {
3232
const {
@@ -39,8 +39,8 @@ const ToggleGroup = React.forwardRef(function ToggleGroup(
3939
value: valueProp,
4040
className,
4141
render,
42-
...otherProps
43-
} = props;
42+
...elementProps
43+
} = componentProps;
4444

4545
const direction = useDirection();
4646

@@ -96,14 +96,14 @@ const ToggleGroup = React.forwardRef(function ToggleGroup(
9696
[disabled, orientation, setGroupValue, groupValue],
9797
);
9898

99-
const renderElement = useRenderElement('div', props, {
99+
const renderElement = useRenderElement('div', componentProps, {
100100
state,
101101
ref: forwardedRef,
102102
props: [
103103
{
104104
role: 'group',
105105
},
106-
otherProps,
106+
elementProps,
107107
],
108108
customStyleHookMapping,
109109
});
@@ -212,7 +212,7 @@ ToggleGroup.propTypes /* remove-proptypes */ = {
212212
* @param {any[]} groupValue An array of the `value`s of all the pressed items.
213213
* @param {Event} event The corresponding event that initiated the change.
214214
*/
215-
onValueChange: PropTypes.func.isRequired,
215+
onValueChange: PropTypes.func,
216216
/**
217217
* @default 'horizontal'
218218
*/

packages/react/src/toggle/Toggle.tsx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import { useButton } from '../use-button/useButton';
1616
* Documentation: [Base UI Toggle](https://base-ui.com/react/components/toggle)
1717
*/
1818
const Toggle = React.forwardRef(function Toggle(
19-
props: Toggle.Props,
19+
componentProps: Toggle.Props,
2020
forwardedRef: React.ForwardedRef<HTMLButtonElement>,
2121
) {
2222
const {
@@ -29,8 +29,8 @@ const Toggle = React.forwardRef(function Toggle(
2929
render,
3030
type, // cannot change button type
3131
value: valueProp,
32-
...otherProps
33-
} = props;
32+
...elementProps
33+
} = componentProps;
3434

3535
const value = valueProp ?? '';
3636

@@ -67,7 +67,7 @@ const Toggle = React.forwardRef(function Toggle(
6767
[disabled, pressed],
6868
);
6969

70-
const renderElement = useRenderElement('button', props, {
70+
const renderElement = useRenderElement('button', componentProps, {
7171
state,
7272
ref: buttonRef,
7373
props: [
@@ -80,7 +80,7 @@ const Toggle = React.forwardRef(function Toggle(
8080
},
8181
ref: buttonRef,
8282
},
83-
otherProps,
83+
elementProps,
8484
getButtonProps,
8585
],
8686
});

0 commit comments

Comments
 (0)