Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom config location #43

Open
IgnisDa opened this issue Nov 13, 2022 · 1 comment
Open

Custom config location #43

IgnisDa opened this issue Nov 13, 2022 · 1 comment
Labels
enhancement New feature or request
Milestone
v0.3.0

Comments

@IgnisDa
Copy link

IgnisDa commented Nov 13, 2022

Thanks for the project, it is really awesome!

Right now, the configuration file is hardcoded to be read from the current directory. Sometimes it becomes necessary to run binserve from a directory which does not have a binserve.json. In this case, it would be great if we have the option to specify the location of the configuration file.
@mufeedvh
Copy link
Owner

mufeedvh commented Nov 22, 2022 •
edited
Loading

Hey @IgnisDa, yeah this was a major oversight, it should've been a command-line argument instead. This is a small change so I will definitely make this the case in the next release!

Thank you for raising this issue glad you liked the project, and sorry for the late reply! 🙌❤️

Same as #34

@mufeedvh mufeedvh added the enhancement New feature or request label Nov 22, 2022
@mufeedvh mufeedvh added this to the v0.3.0 milestone Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.3.0
Development

No branches or pull requests
2 participants
@mufeedvh @IgnisDa