Skip to content

Commit b15b791

Browse files
committed
Make deleteProcess more idiomatic
Signed-off-by: Ettore Di Giacinto <[email protected]>
1 parent 6cc47cb commit b15b791

File tree

1 file changed

+19
-9
lines changed

1 file changed

+19
-9
lines changed

pkg/model/process.go

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,16 +16,26 @@ import (
1616
)
1717

1818
func (ml *ModelLoader) deleteProcess(s string) error {
19-
if m, exists := ml.models[s]; exists {
20-
process := m.Process()
21-
if process != nil {
22-
if err := process.Stop(); err != nil {
23-
log.Error().Err(err).Msgf("(deleteProcess) error while deleting process %s", s)
24-
}
25-
}
19+
defer delete(ml.models, s)
20+
21+
m, exists := ml.models[s]
22+
if !exists {
23+
// Nothing to do
24+
return nil
25+
}
26+
27+
process := m.Process()
28+
if process == nil {
29+
// Nothing to do as there is no process
30+
return nil
2631
}
27-
delete(ml.models, s)
28-
return nil
32+
33+
err := process.Stop()
34+
if err != nil {
35+
log.Error().Err(err).Msgf("(deleteProcess) error while deleting process %s", s)
36+
}
37+
38+
return err
2939
}
3040

3141
func (ml *ModelLoader) StopGRPC(filter GRPCProcessFilter) error {

0 commit comments

Comments
 (0)