Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archlinux mkchromecast-git package targets unstable master branch #446

Open
xsdg opened this issue Jan 4, 2024 · 5 comments
Open

archlinux mkchromecast-git package targets unstable master branch #446

xsdg opened this issue Jan 4, 2024 · 5 comments

Comments

@xsdg
Copy link
Collaborator

xsdg commented Jan 4, 2024

Issue #445 fundamentally results from the fact that I'm in the middle of a large refactor/rewrite of the project, which will unavoidably destabilize the mkchromecast codebase. I think the best approach would be for the aur package to target a more stable branch, potentially with some option for users to point it at the master branch, with the understanding that there's a risk of HEAD being broken.

@benjamb , are you the same person as the benjamb who maintains https://aur.archlinux.org/packages/mkchromecast-git ?

@benjamb
Copy link
Contributor

benjamb commented Jan 4, 2024

I am indeed. -git suffixed packages are development versions of those without the suffix, so it's expected that there will be some instability. After a quick search however, it does appear the stable package no longer exists, so I could create that.

Is there a commit that could be tagged that's more recent than 0.3.8.1 that was released over 6 years ago, but before your recent refactoring.

@xsdg
Copy link
Collaborator Author

xsdg commented Jan 5, 2024

I don't think there's a specific conclusive answer, but here are some datapoints:

  • Debian (unstable through stable) and Ubuntu ship a package based off db2964a1 Updated qt and clean targets on Makefile.; see https://salsa.debian.org/debian/mkchromecast.git . I figure this will be the most-tested version.
  • It looks like you have a PR that was merged after that commit, c046ba2f Merge pull request #376 from benjamb/benbrown/list-regex. I presume you would want this in the stable aur package
  • There were some (automated?) minimal-version bumps after your PR, leading up to the commit 10b91bd4 Merge pull request #409 from muammar/dependabot/npm_and_yarn/nodejs/qs-and-express-6.11.0 from Dec 2022.

I'm open to other ideas and suggestions, but I would be comfortable with creating a stable branch that points to any of those three commits. That said, I don't think I have enough of a grasp on how the project metadata works (or how correct it is) just yet to actually create a new release.

@xsdg
Copy link
Collaborator Author

xsdg commented Jan 5, 2024

@andrewshadura @bgermann FYI, re: the Debian mkchromecast package

@benjamb
Copy link
Contributor

benjamb commented Jan 9, 2024

Something with at least a35a5d9 would be preferable, since it includes various patches (not just my own) to make it pipewire friendly.

@xsdg
Copy link
Collaborator Author

xsdg commented Jan 17, 2024

Okay, I created a stable branch (currently) pointing at the merge commit for the commit you referenced:
https://github.com/muammar/mkchromecast/tree/stable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants