Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Either downgrade or upgrade luassert #12

Open
S-S-X opened this issue May 18, 2023 · 1 comment
Open

Either downgrade or upgrade luassert #12

S-S-X opened this issue May 18, 2023 · 1 comment

Comments

@S-S-X
Copy link
Member

S-S-X commented May 18, 2023

Latest luassert 1.9 has issue with wildcard match formatter:

This can cause issues that are hard to detect at first if tests are passing but very confusing later when tests fail and luassert formatter fails.

Should either upgrade to fixed version (patch seems good) or downgrade to luassert 1.8 which does not have this issue (but also does not have these nice formatters).

@S-S-X
Copy link
Member Author

S-S-X commented May 18, 2023

Pushed latest to https://hub.docker.com/r/mineunit/mineunit with custom built luassert that includes mentioned patch, seems to work without issues.

For command line exec: docker run --rm -it --mount 'type=bind,source=./,target=/home/mineunit/mod' --entrypoint /bin/sh mineunit/mineunit:latest -lc "cd mod; mineunit"

For bash script:
placed in ~/bin/mineunit to allow calling mineunit like if it was actually installed but run in container and allow access only to current directory.

#!/bin/bash
cmd=("cd" "mod;" "mineunit" "${@}")
docker run --rm -it \
        --mount 'type=bind,source=./,target=/home/mineunit/mod' \
        --entrypoint /bin/sh mineunit/mineunit:latest \
        -lc "${cmd[*]}"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant