Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: GraphQL and HTTP Network Errors #2394

Closed
1 task
hinogi opened this issue Dec 14, 2024 · 1 comment
Closed
1 task

FR: GraphQL and HTTP Network Errors #2394

hinogi opened this issue Dec 14, 2024 · 1 comment
Labels

Comments

@hinogi
Copy link

hinogi commented Dec 14, 2024

Scope

Improves an existing behavior

Compatibility

  • This is a breaking change

Feature description

Currently when you use graphql you only have one choice of error, and that is a graphql error that comes with the response. If you have a network connectivity error or trying to request from the wrong url or something you'd usually receive a http error.
Currently graphql.query or graphql.mutation do not expect errors from typeof HttpResponse.error() although they are possible.
The improvement is to extend the error type for allowed graphql responses to also be of type HttpResponse.error() or compatible.

@hinogi hinogi added the feature label Dec 14, 2024
@kettanaito
Copy link
Member

Thanks for opening this, @hinogi. This appears to be a duplicate of #2130, which even has a pull request open. Please see that issue for more details. Thanks.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants