Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immunisation Program: Enrolment form has a buggy patient status selection #6359

Closed
marthakeezy opened this issue Jan 30, 2025 · 5 comments
Closed
Labels
Build Tested: None This issue cannot be build tested or will not be build tested feature: programs needs daily triage New bug to be triaged by the release team needs triage Severity: Low Bugs that don't block workflows. UX like wrong fonts, bad layout

Comments

@marthakeezy
Copy link

What went wrong? 😲

Immunisation Program Enrolment form has a buggy patient status selection: I am unable to clear the selection and then select my previous status. However, if I select another one and then revert back to the original patient status, the changes are saved and OK button disabled.

Screen.Recording.2025-01-31.at.9.46.31.AM.mov

Expected behaviour 🤔

I think you should be able to select the original patient status if accidentally cleared? And if you are clearing the field, it should stay empty with red borders indicating it's a required field, and not just revert back to the selection - especially if you can't save it.

How to Reproduce 🔨

Steps to reproduce the behaviour:

  1. Make sure you have Immunization Program and Vaccination Card set up in your store
  2. Once you do, go to Dispensary -> Patients and select any patient to enrol them in a program
  3. When adding program, you will see an enrolment modal -> select patient status -> Save and close
  4. Re-open -> your selection should be there. Try clearing it -> it reverts back. Try clearing it and selecting the previous status - the behaviour is funky!

Your environment 🌱

  • Open mSupply Version: V2.6.0-build-test-2
  • Legacy mSupply Central Server Version: V7.19.03
  • Platform: Google Chrome (browser for Mac)
  • Database type: PostreSQL
@marthakeezy marthakeezy added needs daily triage New bug to be triaged by the release team needs triage feature: vaccine card Severity: Low Bugs that don't block workflows. UX like wrong fonts, bad layout labels Jan 30, 2025
@marthakeezy marthakeezy changed the title Immunisation Program Enrolment form has a buggy patient status selection Immunisation Program: Enrolment form has a buggy patient status selection Jan 30, 2025
@lache-melvin
Copy link
Contributor

I think this is expected? Status is required, if you don't actually want to set a status you can remove the whole thing with - button. If you change back to original status, then you didn't change anything, so nothing to save?

@lache-melvin
Copy link
Contributor

Agree its not the most intuitive UI, but I don't think it's a bug. Can leave with triage team if we want to spend time improving UX here at this stage 🤷‍♀

@marthakeezy
Copy link
Author

I think if you change back to the original status, the red borders should not be there? Because when you change to another status and back to the original one for example, UI looks different from when you remove the status and re-add it. I think if you remove and re-add it, red borders should not be there?

@lache-melvin
Copy link
Contributor

Ohh I see, because we show the error that the selection was cleared, but then repopulate when you click off, yeah should consolidate that 👍

@marthakeezy
Copy link
Author

Moved to #6376

@marthakeezy marthakeezy added the Build Tested: None This issue cannot be build tested or will not be build tested label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Tested: None This issue cannot be build tested or will not be build tested feature: programs needs daily triage New bug to be triaged by the release team needs triage Severity: Low Bugs that don't block workflows. UX like wrong fonts, bad layout
Projects
None yet
Development

No branches or pull requests

2 participants