Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancelling the new patient form prompts confirmation twice #6349

Open
Chris-Petty opened this issue Jan 30, 2025 · 1 comment
Open

Cancelling the new patient form prompts confirmation twice #6349

Chris-Petty opened this issue Jan 30, 2025 · 1 comment
Labels
needs daily triage New bug to be triaged by the release team needs triage

Comments

@Chris-Petty
Copy link
Contributor

What went wrong? 😲

double.cancel.confirm.mov

Note that navigating away through the left nav menu correctly only confirms once.

Expected behaviour 🤔

Just one confirm is good

How to Reproduce 🔨

Steps to reproduce the behaviour:

  1. New patient
  2. Cancel
  3. Confirm cancel once
  4. Confirm twice!

Your environment 🌱

  • Open mSupply Version: 2.6-dev, haven't tried reproducing on main 2.5
  • Database type: sqlite3
@Chris-Petty Chris-Petty added needs daily triage New bug to be triaged by the release team needs triage labels Jan 30, 2025
@lache-melvin
Copy link
Contributor

This should just be a 2.6 problem after I messed with the useConfirmOnLeaving, happy to take a look at this one 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs daily triage New bug to be triaged by the release team needs triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Chris-Petty @lache-melvin