Sync and Translate for insurance fields on Invoice

[jmbrunskill]

Sync and Translate for insurance fields on Invoice

Tasks

• Add field from mSupply nameInsuranceJoinId as name_insurance_join_id
• Add field from mSupply insuranceDiscountAmount as insurance_discount_amount
• Add field from mSupply insuranceDiscountRate as insurance_discount_percentage

Acceptance Criteria 🧾

• Can sync these fields above with mSupply
• Test cases added/updated to include these fields

Epic Link 🔗

#6000

Moneyworks Jobcode 🧰

OMS:CIDV

[CarlosNZ]

• Add field from mSupply insuranceDiscountRate as insurance_discount_percentage

@jmbrunskill - just wondering, why do we need to add this field to invoice table, when it's already in the name_insurance_join which we're going to reference by id already?

Add field from mSupply insuranceDiscountAmount as insurance_discount_amount

Presumably this is the discount percentage x the invoice total? Why do we need to store this in DB when we can just derive it from those two values?

[jmbrunskill]

• Add field from mSupply insuranceDiscountRate as insurance_discount_percentage

@jmbrunskill - just wondering, why do we need to add this field to invoice table, when it's already in the name_insurance_join which we're going to reference by id already?

Add field from mSupply insuranceDiscountAmount as insurance_discount_amount

Presumably this is the discount percentage x the invoice total? Why do we need to store this in DB when we can just derive it from those two values?

It's possible to change the discount rate on an existing policy, so I think the goal of capturing it on the invoice is probably to make sure we capture the values at the time of the invoice, but not 100% why it was done this way. That being said I think changing existing policies will be a rare thing.

@andreievg would you be comfortable to just do lookups in this case? I'm still leaning towards copying mSupply here.

We need to at least sync those fields to mSupply though as we want to make sure any existing reports etc keep working with OMS sites. That would just mean doing that lookup/join in the sync stage though.