Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot delete lines - error message could be clearer #5128

Closed
regotaina opened this issue Oct 15, 2024 · 5 comments · Fixed by #5226
Closed

Cannot delete lines - error message could be clearer #5128

regotaina opened this issue Oct 15, 2024 · 5 comments · Fixed by #5226
Assignees
Labels
bug Something is borken feature: manual requisition Severity: Low Bugs that don't block workflows. UX like wrong fonts, bad layout Team Ruru 🦉 Roxy, Ferg, Noel Tester: Alain Alain is testing this
Milestone

Comments

@regotaina
Copy link
Contributor

What went wrong? 😲

found accidentally while testing remote authorisation.

In Requisitions received from a store, you cannot delete any lines. Expected behaviour.
However message is currently "deleted response lines not yet implemented in API" which can be confusing for users.

Screenshot 2024-10-15 at 2 24 11 PM

Expected behaviour 🤔

Possible alternative text like " you cannot delete lines of this requisition"

How to Reproduce 🔨

Steps to reproduce the behaviour:

  1. Create IO from Store A to supplying Store B
  2. Confirm sent
  3. Login to Store B
  4. Go to Requisitions
  5. Try to delete any line from the requisition received form Store A
  6. See error message

Your environment 🌱

  • Open mSupply Version: V2.3.0RC8
  • Legacy mSupply Central Server Version: V7.17
  • Platform: browser
@regotaina regotaina added bug Something is borken needs triage needs daily triage New bug to be triaged by the release team labels Oct 15, 2024
@lache-melvin lache-melvin added Severity: Low Bugs that don't block workflows. UX like wrong fonts, bad layout and removed needs daily triage New bug to be triaged by the release team labels Oct 15, 2024
@lache-melvin
Copy link
Contributor

If deleting response requisition lines isn't supported yet, shouldn't we just remove the delete selected lines action from the UI?

@roxy-dao
Copy link
Contributor

If deleting response requisition lines isn't supported yet, shouldn't we just remove the delete selected lines action from the UI?

Should be implemented for manual requisitions though... in case someone does add a wrong line?

@lache-melvin
Copy link
Contributor

Should be implemented for manual requisitions though... in case someone does add a wrong line?

Ah great point! Maybe this one can be resolved as part of manual requisition work 🙏

@andreievg
Copy link
Collaborator

We shouldn't be able to delete lines in transfer requisition, so should hide that option. But yeah that option should be available in manual requisition, I think we can solve as part of manual requisition work

@roxy-dao roxy-dao added this to the V2.4.0 milestone Oct 24, 2024
@roxy-dao roxy-dao linked a pull request Oct 24, 2024 that will close this issue
5 tasks
@alainsussol alainsussol added the Tester: Alain Alain is testing this label Nov 12, 2024
@alainsussol
Copy link

Will be tested as part of Epic testing. See Results here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is borken feature: manual requisition Severity: Low Bugs that don't block workflows. UX like wrong fonts, bad layout Team Ruru 🦉 Roxy, Ferg, Noel Tester: Alain Alain is testing this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants