From 8110aca57d3f669777a2286be70b87f8ecf3d8d1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lach=C3=A9=20Melvin?= <55115239+lache-melvin@users.noreply.github.com> Date: Wed, 23 Oct 2024 17:14:40 +1300 Subject: [PATCH 1/3] reference base branch correctly --- .github/workflows/client-bundle-size-diff.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/client-bundle-size-diff.yaml b/.github/workflows/client-bundle-size-diff.yaml index 2965bde8c3..0ce44a20e0 100644 --- a/.github/workflows/client-bundle-size-diff.yaml +++ b/.github/workflows/client-bundle-size-diff.yaml @@ -14,7 +14,7 @@ jobs: - name: Checkout uses: actions/checkout@v4 with: - ref: ${{ github.ref }} + ref: ${{ github.base_ref }} - name: Read .nvmrc run: echo "##[set-output name=NVMRC;]$(cat ./client/.nvmrc)" From e4d36e3ca239c1f34e912bc64a77ed131c5bc95f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lach=C3=A9=20Melvin?= <55115239+lache-melvin@users.noreply.github.com> Date: Wed, 23 Oct 2024 17:16:35 +1300 Subject: [PATCH 2/3] trigger --- client/packages/system/src/Item/DetailView/DetailView.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/client/packages/system/src/Item/DetailView/DetailView.tsx b/client/packages/system/src/Item/DetailView/DetailView.tsx index cb3ddfaeff..e61863cd44 100644 --- a/client/packages/system/src/Item/DetailView/DetailView.tsx +++ b/client/packages/system/src/Item/DetailView/DetailView.tsx @@ -44,6 +44,8 @@ export const ItemDetailView: FC = () => { }, ]; + console.log('ADDING SOME EXCITING TEST CODE'); + Environment.FEATURE_PACK_VARIANTS && tabs.push({ Component: , From 47737a088b82816fd295a2ccc8e9c040fd75756a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lach=C3=A9=20Melvin?= <55115239+lache-melvin@users.noreply.github.com> Date: Wed, 23 Oct 2024 17:17:38 +1300 Subject: [PATCH 3/3] revert the cursed console.log --- client/packages/system/src/Item/DetailView/DetailView.tsx | 2 -- 1 file changed, 2 deletions(-) diff --git a/client/packages/system/src/Item/DetailView/DetailView.tsx b/client/packages/system/src/Item/DetailView/DetailView.tsx index e61863cd44..cb3ddfaeff 100644 --- a/client/packages/system/src/Item/DetailView/DetailView.tsx +++ b/client/packages/system/src/Item/DetailView/DetailView.tsx @@ -44,8 +44,6 @@ export const ItemDetailView: FC = () => { }, ]; - console.log('ADDING SOME EXCITING TEST CODE'); - Environment.FEATURE_PACK_VARIANTS && tabs.push({ Component: ,