Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "required" asterisk when label is not shown #1625

Open
CarlosNZ opened this issue Jan 23, 2024 · 0 comments
Open

Show "required" asterisk when label is not shown #1625

CarlosNZ opened this issue Jan 23, 2024 · 0 comments
Labels
Importance: Nice to have Issues that don't need to be included, just nice to have

Comments

@CarlosNZ
Copy link
Collaborator

Currently, the isRequired indicator (asterisk) shows up as part of the label (that's baked into Semantic-UI).

Screenshot 2024-01-24 at 8 51 34 AM

However, in cases when we don't show the label (such as in the italicised element above), there's no visual indication that the question is required.

Possible remedies:

  • Find a way to override the styling of the label (i.e not bolded), and then use the label instead of the description in cases like this
  • Add the indicator to the description in cases where the label is undefined

The tricky thing with both of these approaches is that we don't really want to apply the logic to every single element — it would better if it it could take place at the "Wrapper" level. But the wrapper would then have to pass the info about where to show the required indicator to each element.

Maybe we can add a CSS class to the wrapper on elements with a missing label that are required, then do it with CSS styling?

@CarlosNZ CarlosNZ added the Importance: Nice to have Issues that don't need to be included, just nice to have label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Importance: Nice to have Issues that don't need to be included, just nice to have
Projects
None yet
Development

No branches or pull requests

1 participant